Skip to content

Commit 72d79bd

Browse files
committed
update: phase update will return members
1 parent 7f02ec1 commit 72d79bd

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

src/routes/phases/update.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,15 @@ const updateProjectPhaseValidation = {
2626
order: Joi.number().integer().optional(),
2727
}).required(),
2828
};
29-
29+
const populateMemberDetails = async (phase, req) => {
30+
const members = _.map(phase.members, member => _.pick(member, 'userId'));
31+
try {
32+
const detailedMembers = await util.getObjectsWithMemberDetails(members, ['userId', 'handle', 'photoURL'], req);
33+
return _.assign(phase, { members: detailedMembers });
34+
} catch (err) {
35+
return _.assign(phase, { members });
36+
}
37+
};
3038

3139
module.exports = [
3240
// validate request payload
@@ -102,8 +110,14 @@ module.exports = [
102110
updatedValue,
103111
previousValue,
104112
ROUTES.PHASES.UPDATE);
105-
106-
res.json(updated);
113+
return models.ProjectPhase.findOne({
114+
where: { id: phaseId, projectId },
115+
include: [{
116+
model: models.ProjectPhaseMember,
117+
as: 'members',
118+
}],
119+
}).then(phaseWithMembers => populateMemberDetails(phaseWithMembers.toJSON(), req)
120+
.then(result => res.json(result)));
107121
})
108122
.catch(err => next(err));
109123
},

0 commit comments

Comments
 (0)