Skip to content

Commit 6a5cad6

Browse files
author
vikasrohit
authored
Merge pull request #206 from topcoder-platform/hotfix/silent_ignore_missing_user_details_for_es_index
Ignoring the missing member details for new project creation to reduce the number of errors on production and reduce the customer loss
2 parents 3736a6e + 077d9d4 commit 6a5cad6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/events/projects/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ const indexProject = Promise.coroutine(function* (logger, msg) { // eslint-disab
2828
// retrieve member details
2929
const memberDetails = yield util.getMemberDetailsByUserIds(userIds, msg.properties.correlationId, logger);
3030
// if no members are returned than this should result in nack
31-
if (!_.isArray(memberDetails) || memberDetails.length === 0) {
32-
logger.error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
33-
throw new Error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
34-
}
31+
// if (!_.isArray(memberDetails) || memberDetails.length === 0) {
32+
// logger.error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
33+
// throw new Error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
34+
// }
3535
// update project member record with details
3636
data.members = data.members.map((single) => {
3737
const detail = _.find(memberDetails, md => md.userId === single.userId);

0 commit comments

Comments
 (0)