Skip to content

Commit 675a42b

Browse files
author
Maksym Mykhailenko
committed
fix: milestone start/complete date validation
1 parent 89be03b commit 675a42b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/routes/milestones/commonHelper.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,11 @@ async function updateMilestone(authUser, timelineId, data, transaction, item) {
116116

117117
// only admins can update values of 'completionDate' and 'actualStartDate' if they are already set
118118
const isUpdatedCompletionDate = milestone.completionDate && entityToUpdate.completionDate
119-
&& milestone.completionDate !== entityToUpdate.completionDate;
119+
&& !moment(milestone.completionDate).isSame(entityToUpdate.completionDate);
120120
const isUpdatedActualStartDate = milestone.actualStartDate && entityToUpdate.actualStartDate
121-
&& milestone.actualStartDate !== entityToUpdate.actualStartDate;
121+
&& !moment(milestone.actualStartDate).isSame(entityToUpdate.actualStartDate);
122+
123+
122124
if (
123125
(isUpdatedCompletionDate || isUpdatedActualStartDate)
124126
&& !util.hasPermission({ topcoderRoles: ADMIN_ROLES }, authUser)

0 commit comments

Comments
 (0)