Skip to content

Commit 63e017a

Browse files
committed
Merge branch 'dev-auth0' into dev
2 parents e07c21d + 4e556f6 commit 63e017a

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/middlewares/checkRole.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ const util = require('tc-core-library-js').util(config);
1212

1313
module.exports = function defineCheckRole(roleName) {
1414
return function checkRoleMiddleware(req, res, next) {
15-
if (!req.authUser || !Array.isArray(req.authUser.roles) ||
16-
req.authUser.roles.indexOf(roleName) === -1) {
15+
const roles = req.authUser ? util.getRoles(req.authUser) : null;
16+
if (!Array.isArray(roles) ||
17+
roles.indexOf(roleName) === -1) {
1718
return res.status(403)
1819
.json(util.wrapErrorResponse(req.id, 403, 'You are not allowed to perform this action.'));
1920
}

src/routes/projects/update.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ const validateUpdates = (existingProject, updatedProps, authUser) => {
9999
// }
100100
}
101101
if (_.has(updatedProps, 'directProjectId') &&
102-
_.intersection(authUser.roles, [USER_ROLE.MANAGER, USER_ROLE.TOPCODER_ADMIN]).length === 0) {
102+
_.intersection(util.getRoles(authUser), [USER_ROLE.MANAGER, USER_ROLE.TOPCODER_ADMIN]).length === 0) {
103103
errors.push('Don\'t have permission to update \'directProjectId\' property');
104104
}
105105

src/util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ _.assignIn(util, {
6969
* @return {boolean} true/false
7070
*/
7171
hasRole: (req, role) => {
72-
let roles = _.get(req, 'authUser.roles', []);
72+
let roles = req.authUser ? util.getRoles(req.authUser) : [];
7373
roles = roles.map(s => s.toLowerCase());
7474
return _.indexOf(roles, role.toLowerCase()) >= 0;
7575
},

0 commit comments

Comments
 (0)