Skip to content

Commit 4ee34bf

Browse files
committed
feat: make milestone texts optional
Make the next milestone properties optional: plannedText activeText completedText blockedText
1 parent 9df0aca commit 4ee34bf

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
--
2+
-- UPDATE EXISTING TABLES:
3+
-- milestones
4+
5+
ALTER TABLE milestones ALTER COLUMN "plannedText" DROP NOT NULL;
6+
ALTER TABLE milestones ALTER COLUMN "activeText" DROP NOT NULL;
7+
ALTER TABLE milestones ALTER COLUMN "completedText" DROP NOT NULL;
8+
ALTER TABLE milestones ALTER COLUMN "blockedText" DROP NOT NULL;

src/models/milestone.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ module.exports = (sequelize, DataTypes) => {
6666
type: { type: DataTypes.STRING(45), allowNull: false },
6767
details: DataTypes.JSON,
6868
order: { type: DataTypes.INTEGER, allowNull: false },
69-
plannedText: { type: DataTypes.STRING(512), allowNull: false },
70-
activeText: { type: DataTypes.STRING(512), allowNull: false },
71-
completedText: { type: DataTypes.STRING(512), allowNull: false },
72-
blockedText: { type: DataTypes.STRING(512), allowNull: false },
69+
plannedText: { type: DataTypes.STRING(512) },
70+
activeText: { type: DataTypes.STRING(512) },
71+
completedText: { type: DataTypes.STRING(512) },
72+
blockedText: { type: DataTypes.STRING(512) },
7373
hidden: { type: DataTypes.BOOLEAN, defaultValue: false },
7474
deletedAt: DataTypes.DATE,
7575
createdAt: { type: DataTypes.DATE, defaultValue: DataTypes.NOW },

src/routes/milestones/create.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ const schema = {
3131
type: Joi.string().max(45).required(),
3232
details: Joi.object(),
3333
order: Joi.number().integer().required(),
34-
plannedText: Joi.string().max(512).required(),
35-
activeText: Joi.string().max(512).required(),
36-
completedText: Joi.string().max(512).required(),
37-
blockedText: Joi.string().max(512).required(),
34+
plannedText: Joi.string().max(512),
35+
activeText: Joi.string().max(512),
36+
completedText: Joi.string().max(512),
37+
blockedText: Joi.string().max(512),
3838
hidden: Joi.boolean().optional(),
3939
createdAt: Joi.any().strip(),
4040
updatedAt: Joi.any().strip(),

0 commit comments

Comments
 (0)