Skip to content

Commit 4da2fb5

Browse files
author
vikasrohit
authored
Merge pull request #227 from topcoder-platform/hotfix/debug_logs
Fixing issue found in project creation during smoke test
2 parents 793f028 + bafbae7 commit 4da2fb5

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/events/projectMembers/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ const projectMemberUpdatedHandler = Promise.coroutine(function* a(logger, msg, c
178178
try {
179179
const data = JSON.parse(msg.content.toString());
180180
// get member information
181-
const memberDetails = yield util.getMemberDetailsByUserIds[data.original.userId];
181+
const memberDetails = yield util.getMemberDetailsByUserIds([data.original.userId], logger);
182182
const payload = _.merge(data.updated, _.pick(memberDetails[0], 'handle', 'firstName', 'lastName', 'email'));
183183
const doc = yield eClient.get({ index: ES_PROJECT_INDEX, type: ES_PROJECT_TYPE, id: data.original.projectId });
184184

src/events/projects/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const indexProject = Promise.coroutine(function* (logger, msg) { // eslint-disab
2626
const userIds = data.members ? data.members.map(single => `userId:${single.userId}`) : [];
2727
try {
2828
// retrieve member details
29-
const memberDetails = yield util.getMemberDetailsByUserIds(userIds, msg.properties.correlationId, logger);
29+
const memberDetails = yield util.getMemberDetailsByUserIds(userIds, logger, msg.properties.correlationId);
3030
// if no members are returned than this should result in nack
3131
// if (!_.isArray(memberDetails) || memberDetails.length === 0) {
3232
// logger.error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);

src/util.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,9 @@ _.assignIn(util, {
335335
try {
336336
const token = yield this.getSystemUserToken(logger);
337337
const httpClient = this.getHttpClient({ id: requestId, log: logger });
338-
logger.trace(userIds);
338+
if (logger) {
339+
logger.trace(userIds);
340+
}
339341
return httpClient.get(`${config.memberServiceEndpoint}/_search`, {
340342
params: {
341343
query: `${userIds.join(urlencode(' OR ', 'utf8'))}`,

0 commit comments

Comments
 (0)