reverted the raise of phase event from milestone event. Milestone events should be consumed by project service and raise the phase updated event instead.

Author: Vikas Agarwal

src/events/busApi.js

@@ -428,28 +428,25 @@ module.exports = (app, logger) => {
     logger.debug('sendMilestoneNotification', original, updated);
     // Send transition events
     if (original.status !== updated.status) {
-      let events;
+      let event;
       if (updated.status === MILESTONE_STATUS.COMPLETED) {
-        // on milestone completion, raise milestone completion and project phase progress events
-        events = [BUS_API_EVENT.MILESTONE_TRANSITION_COMPLETED, BUS_API_EVENT.PROJECT_PHASE_UPDATE_PROGRESS];
+        event = BUS_API_EVENT.MILESTONE_TRANSITION_COMPLETED;
       } else if (updated.status === MILESTONE_STATUS.ACTIVE) {
-        events = [BUS_API_EVENT.MILESTONE_TRANSITION_ACTIVE];
+        event = BUS_API_EVENT.MILESTONE_TRANSITION_ACTIVE;
       }
 
-      if (events) {
-        events.forEach((event) => {
-          createEvent(event, {
-            projectId: project.id,
-            projectName: project.name,
-            projectUrl: connectProjectUrl(project.id),
-            timelineId: req.timeline.id,
-            timelineName: req.timeline.name,
-            originalMilestone: original,
-            updatedMilestone: updated,
-            userId: req.authUser.userId,
-            initiatorUserId: req.authUser.userId,
-          }, logger);
-        });
+      if (event) {
+        createEvent(event, {
+          projectId: project.id,
+          projectName: project.name,
+          projectUrl: connectProjectUrl(project.id),
+          timelineId: req.timeline.id,
+          timelineName: req.timeline.name,
+          originalMilestone: original,
+          updatedMilestone: updated,
+          userId: req.authUser.userId,
+          initiatorUserId: req.authUser.userId,
+        }, logger);
       }
     }