Revert "fix: temporary fix to index TaaS project with skills"

This reverts commit 1c24d2a.

Author: maxceem

src/events/projects/index.js

@@ -41,10 +41,6 @@ const indexProject = Promise.coroutine(function* (logger, msg) { // eslint-disab
       // removes non required fields from phase objects
       data.phases = data.phases.map(phase => _.omit(phase, ['deletedAt', 'deletedBy']));
     }
-    // TEMPORARY FIX: should fix ES mapping instead and reindex all the projects instead
-    if (typeof _.get(data, 'details.taasDefinition.team.skills') !== 'string') {
-      _.set(data, 'details.taasDefinition.team.skills', '');
-    }
     // add the record to the index
     const result = yield eClient.index({
       index: ES_PROJECT_INDEX,
@@ -95,10 +91,6 @@ const projectUpdatedHandler = Promise.coroutine(function* (logger, msg, channel)
     // first get the existing document and than merge the updated changes and save the new document
     const doc = yield eClient.get({ index: ES_PROJECT_INDEX, type: ES_PROJECT_TYPE, id: data.original.id });
     const merged = _.merge(doc._source, data.updated);        // eslint-disable-line no-underscore-dangle
-    // TEMPORARY FIX: should fix ES mapping instead and reindex all the projects instead
-    if (typeof _.get(merged, 'details.taasDefinition.team.skills') !== 'string') {
-      _.set(merged, 'details.taasDefinition.team.skills', '');
-    }
     // update the merged document
     yield eClient.update({
       index: ES_PROJECT_INDEX,
@@ -181,10 +173,6 @@ async function projectUpdatedKafkaHandler(app, topic, payload) {
   try {
     const doc = await eClient.get({ index: ES_PROJECT_INDEX, type: ES_PROJECT_TYPE, id: previousValue.id });
     const merged = _.merge(doc._source, project.get({ plain: true }));        // eslint-disable-line no-underscore-dangle
-    // TEMPORARY FIX: should fix ES mapping instead and reindex all the projects instead
-    if (typeof _.get(merged, 'details.taasDefinition.team.skills') !== 'string') {
-      _.set(merged, 'details.taasDefinition.team.skills', '');
-    }
     // update the merged document
     await eClient.update({
       index: ES_PROJECT_INDEX,

src/routes/admin/project-index-create.js

@@ -97,10 +97,6 @@ module.exports = [
         projectResponses.map((p) => {
           if (p) {
             body.push({ index: { _index: indexName, _type: docType, _id: p.id } });
-            // TEMPORARY FIX: should fix ES mapping instead and reindex all the projects instead
-            if (typeof _.get(p, 'details.taasDefinition.team.skills') !== 'string') {
-              _.set(p, 'details.taasDefinition.team.skills', '');
-            }
             body.push(p);
           }
           // dummy return