Skip to content

Commit 18b880b

Browse files
committed
Fix reports tests
1 parent d08f9f3 commit 18b880b

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

src/routes/projectReports/getEmbedReport.spec.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -140,26 +140,26 @@ describe('GET embed report', () => {
140140
.set({
141141
Authorization: `Bearer ${testUtil.jwts.member}`,
142142
})
143-
.expect('Content-Type', /json/)
144-
.expect(404, () => {
143+
.expect(404, (err) => {
145144
cfg.restore();
146-
done();
145+
done(err);
147146
});
148147
});
149148

150149
it('should return 500 when get admin user error', (done) => {
151150
const cfg = sinon.stub(config, 'get');
152151
const gem = sinon.stub(lookerSerivce, 'generateEmbedUrl', () => 'generatedUrl');
153152
cfg.withArgs('lookerConfig.USE_MOCK').returns(false);
153+
cfg.withArgs('lookerConfig.EMBED_REPORTS_MAPPING').returns('{"mock-concrete-customer": "/embed/looks/2"}');
154154
request(server)
155155
.get(`/v5/projects/${project1.id}/reports/embed?reportName=mock`)
156156
.set({
157157
Authorization: `Bearer ${testUtil.jwts.admin}`,
158158
})
159-
.expect(500, () => {
159+
.expect(500, (err) => {
160160
gem.restore();
161161
cfg.restore();
162-
done();
162+
done(err);
163163
});
164164
});
165165

@@ -173,11 +173,10 @@ describe('GET embed report', () => {
173173
.set({
174174
Authorization: `Bearer ${testUtil.jwts.member}`,
175175
})
176-
.expect('Content-Type', /json/)
177-
.expect(404, () => {
176+
.expect(404, (err) => {
178177
gem.restore();
179178
cfg.restore();
180-
done();
179+
done(err);
181180
});
182181
});
183182

src/routes/projectReports/getReport.spec.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,9 @@ describe('GET report', () => {
153153
.set({
154154
Authorization: `Bearer ${testUtil.jwts.member}`,
155155
})
156-
.expect('Content-Type', /json/)
157-
.expect(404, () => {
156+
.expect(404, (err) => {
158157
cfg.restore();
159-
done();
158+
done(err);
160159
});
161160
});
162161

0 commit comments

Comments
 (0)