Skip to content

Commit 04ed897

Browse files
author
Vikas Agarwal
committed
Fixed unit tests
1 parent a40bc20 commit 04ed897

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/routes/projectMemberInvites/create.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ const buildCreateInvitePromises = (req, invite, invites, data) => {
9393
});
9494

9595
return Promise.resolve(invitePromises);
96+
}).catch((error) => {
97+
req.log.error(error);
98+
return Promise.reject(invitePromises);
9699
});
97100
}
98101

@@ -106,7 +109,7 @@ const sendInviteEmail = (req, projectId, invite) => {
106109
where: { id: projectId },
107110
raw: true,
108111
}),
109-
util.getMemberDetailsByUserIds(req.authUser.userId, req.logger, req.id),
112+
util.getMemberDetailsByUserIds(req.authUser.userId, req.log, req.id),
110113
];
111114
return Promise.all(promises).then((responses) => {
112115
const project = responses[0];
@@ -142,6 +145,8 @@ const sendInviteEmail = (req, projectId, invite) => {
142145
},
143146
categories: [`${process.env.NODE_ENV}:${emailEventType}`.toLowerCase()],
144147
}, req.log);
148+
}).catch((error) => {
149+
req.log.error(error);
145150
});
146151
};
147152

@@ -243,7 +248,7 @@ module.exports = [
243248
);
244249
// send email invite (async)
245250
if (v.email && !v.userId) {
246-
sendInviteEmail(req, v);
251+
sendInviteEmail(req, projectId, v);
247252
}
248253
});
249254
return values;

src/routes/projectMemberInvites/create.spec.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,11 @@ describe('Project Member Invite create', () => {
8888
sinon.stub(server.services.pubsub, 'publish', () => {});
8989
// by default mock lookupUserEmails return nothing so all the cases are not broken
9090
sandbox.stub(util, 'lookupUserEmails', () => Promise.resolve([]));
91+
sandbox.stub(util, 'getMemberDetailsByUserIds', () => Promise.resolve([{
92+
userId: 40051333,
93+
firstName: 'Admin',
94+
lastName: 'User',
95+
}]));
9196
});
9297
afterEach(() => {
9398
sandbox.restore();

0 commit comments

Comments
 (0)