Skip to content

Commit fb15cd5

Browse files
author
Vikas Agarwal
committed
Github issue#2705, Blue Action Button in Connect-generated emails not working for Outlook users
— Fixed. Removed table inside anchor tag. Instead achieved centre aligned text of the button using paddings.
1 parent f4ac768 commit fb15cd5

File tree

9 files changed

+18
-72
lines changed

9 files changed

+18
-72
lines changed

‎emails/src/partials/project-files.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@
6060
<td class="empty-child-one"></td>
6161
<td class="second-child" align="center">
6262
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}">
63-
<table>
64-
<tr><td align="center">View project on Connect</td></tr>
65-
</table>
63+
View project on Connect
6664
</a>
6765
</td>
6866
<td class="empty-child-one"></td>

‎emails/src/partials/project-links.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@
3131
<td class="empty-child-one"></td>
3232
<td class="second-child" align="center">
3333
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}">
34-
<table>
35-
<tr><td align="center">View project on Connect</td></tr>
36-
</table>
34+
View project on Connect
3735
</a>
3836
</td>
3937
<td class="empty-child-one"></td>

‎emails/src/partials/project-plan.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,7 @@
9797
<td class="empty-child-one"></td>
9898
<td class="second-child" align="center">
9999
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}/plan">
100-
<table>
101-
<tr><td align="center">View plan on Connect</td></tr>
102-
</table>
100+
View plan on Connect
103101
</a>
104102
</td>
105103
<td class="empty-child-one"></td>

‎emails/src/partials/project-specification.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@
3030
<td class="empty-child-one"></td>
3131
<td class="second-child" align="center">
3232
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}">
33-
<table>
34-
<tr><td align="center">View project on Connect</td></tr>
35-
</table>
33+
View project on Connect
3634
</a>
3735
</td>
3836
<td class="empty-child-one"></td>

‎emails/src/partials/project-status.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@
8282
<td class="empty-child-one"></td>
8383
<td class="second-child" align="center">
8484
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}">
85-
<table>
86-
<tr><td align="center">View project on Connect</td></tr>
87-
</table>
85+
View project on Connect
8886
</a>
8987
</td>
9088
<td class="empty-child-one"></td>

‎emails/src/partials/project-team.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@
7979
<td class="empty-child-one"></td>
8080
<td class="second-child" align="center">
8181
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}">
82-
<table>
83-
<tr><td align="center">View project on Connect</td></tr>
84-
</table>
82+
View project on Connect
8583
</a>
8684
</td>
8785
<td class="empty-child-one"></td>

‎emails/src/partials/topics_and_posts.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,7 @@
171171
<td class="empty-child-one"></td>
172172
<td class="second-child" align="center">
173173
<a href="{{@root.connectURL}}/projects/{{notifications.[0].projectId}}#feed-{{notifications.[0].topicId}}">
174-
<table>
175-
<tr><td align="center">View post on Connect</td></tr>
176-
</table>
174+
View post on Connect
177175
</a>
178176
</td>
179177
<td class="empty-child-one"></td>

‎emails/src/styles/main.css

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -210,24 +210,16 @@ table.container, table.footer-container {
210210
background-color: #0681FF;
211211
height: 30px; }
212212
.button-row .main-child .second-child a {
213-
height: 30px;
214213
border-radius: 4px;
215214
text-align: center;
216215
text-decoration: none;
217216
display: block;
218-
background-color: #0681FF; }
219-
.button-row .main-child .second-child a table {
220-
background-color: #0681FF;
221-
border-radius: 4px;
222-
height: 30px; }
223-
.button-row .main-child .second-child a table td {
224-
height: 30px;
225-
background-color: #0681FF;
226-
border-radius: 4px;
227-
vertical-align: middle;
228-
text-align: center;
229-
color: #FFFFFF;
230-
font-size: 13px; }
217+
background-color: #0681FF;
218+
padding-top: 6px;
219+
padding-bottom: 5px;
220+
text-align: center;
221+
color: #FFFFFF;
222+
font-size: 13px; }
231223

232224
.button-one .main-child .empty-child-one, .button-three .main-child .empty-child-one {
233225
width: 216px; }
@@ -236,8 +228,6 @@ table.container, table.footer-container {
236228
width: 167px; }
237229
.button-one .main-child .second-child a, .button-three .main-child .second-child a {
238230
width: 167px; }
239-
.button-one .main-child .second-child a table td, .button-three .main-child .second-child a table td {
240-
width: 167px; }
241231

242232
.button-two .main-child .empty-child-one {
243233
width: 211px; }
@@ -246,8 +236,6 @@ table.container, table.footer-container {
246236
width: 178px; }
247237
.button-two .main-child .second-child a {
248238
width: 178px; }
249-
.button-two .main-child .second-child a table td {
250-
width: 178px; }
251239

252240
.button-four .main-child .empty-child-one {
253241
width: 210px; }
@@ -256,8 +244,6 @@ table.container, table.footer-container {
256244
width: 180px; }
257245
.button-four .main-child .second-child a {
258246
width: 180px; }
259-
.button-four .main-child .second-child a table td {
260-
width: 180px; }
261247

262248
.copy-link {
263249
height: 20px; }

‎emails/src/styles/partials/_base.scss

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -310,27 +310,16 @@ table.container, table.footer-container {
310310
height: 30px;
311311
a {
312312
// width: 167px;
313-
height: 30px;
314313
border-radius: 4px;
315314
text-align: center;
316315
text-decoration: none;
317316
display: block;
318317
background-color: $button-color;
319-
table {
320-
background-color: $button-color;
321-
border-radius: 4px;
322-
height: 30px;
323-
td {
324-
height: 30px;
325-
background-color: $button-color;
326-
border-radius: 4px;
327-
// width: 167px;
328-
vertical-align: middle;
329-
text-align: center;
330-
color: $white-background;
331-
font-size: 13px;
332-
}
333-
}
318+
padding-top: 6px;
319+
padding-bottom: 5px;
320+
text-align: center;
321+
color: $white-background;
322+
font-size: 13px;
334323
}
335324
}
336325
}
@@ -348,11 +337,6 @@ table.container, table.footer-container {
348337
width: 167px;
349338
a {
350339
width: 167px;
351-
table {
352-
td {
353-
width: 167px;
354-
}
355-
}
356340
}
357341
}
358342
}
@@ -367,11 +351,6 @@ table.container, table.footer-container {
367351
width: 178px;
368352
a {
369353
width: 178px;
370-
table {
371-
td {
372-
width: 178px;
373-
}
374-
}
375354
}
376355
}
377356
}
@@ -386,11 +365,6 @@ table.container, table.footer-container {
386365
width: 180px;
387366
a {
388367
width: 180px;
389-
table {
390-
td {
391-
width: 180px;
392-
}
393-
}
394368
}
395369
}
396370
}

0 commit comments

Comments
 (0)