Clean handling of cdderbot initiated messages, they would be ignored without runtime error

Author: Vikas Agarwal

connect/config.js

@@ -17,6 +17,7 @@ module.exports = {
   ADMINISTRATOR_ROLE_ID: 1,
   // id of the BOT user which creates post with various events in discussions
   TCWEBSERVICE_ID: process.env.TCWEBSERVICE_ID || '22838965',
+  CODERBOT_USER_ID: process.env.CODERBOT_USER_ID || 'CoderBot',
 
   // Configuration for generating machine to machine auth0 token.
   // The token will be used for calling another internal API.

connect/connectNotificationServer.js

@@ -272,8 +272,9 @@ notificationServer.setConfig({ LOG_LEVEL: 'debug' });
 // it is defined as: function(topic, message, callback),
 // the topic is topic name,
 // the message is JSON event message,
+// logger object used to log in parent thread
 // the callback is function(error, userIds), where userIds is an array of user ids to receive notifications
-const handler = (topic, message, callback) => {
+const handler = (topic, message, logger, callback) => {
   const projectId = message.projectId;
   if (!projectId) {
     return callback(new Error('Missing projectId in the event message.'));
@@ -286,7 +287,9 @@ const handler = (topic, message, callback) => {
 
   // filter out `notifications.connect.project.topic.created` events send by bot
   // because they create too much clutter and duplicate info
-  if (topic === BUS_API_EVENT.CONNECT.TOPIC.CREATED && message.userId.toString() === config.TCWEBSERVICE_ID) {
+  const botIds = [config.TCWEBSERVICE_ID, config.CODERBOT_USER_ID];
+  if (topic === BUS_API_EVENT.CONNECT.TOPIC.CREATED && botIds.contains(message.userId.toString())) {
+    logger.info(`Ignoring, to avoid noise, Bot topic ${topic}`);
     return callback(null, []);
   }
 

src/app.js

@@ -48,7 +48,7 @@ function startKafkaConsumer(handlers, notificationServiceHandlers) {
     const messageJSON = busPayload.payload;
     const handlerAsync = Promise.promisify(handler);
     // use handler to create notification instances for each recipient
-    return handlerAsync(topicName, messageJSON)
+    return handlerAsync(topicName, messageJSON, logger)
       .then((notifications) => Promise.all(_.map(notifications, (notification) => {
         notification.contents = _.extend({}, messageJSON, notification.contents);
         // run other notification service handlers