adding logic for user group checking.

Author: Sachin Maheshwari

src/common/broadcastAPIHelper.js

@@ -15,74 +15,136 @@ async function getM2MToken() {
     return m2m.getMachineToken(config.AUTH0_CLIENT_ID, config.AUTH0_CLIENT_SECRET)
 }
 
+/**
+ * Helper Function - get member profile 
+ * @param {Integer} userId 
+ */
 async function getMemberInfo(userId) {
     const url = config.TC_API_V3_BASE_URL +
-        `/members/_search/?fields=userId%2Cskills&query=userId%3A${userId}&limit=1`
-    return new Promise(function (resolve, reject) {
+        "/members/_search/?" +
+        "fields=userId%2Cskills" +
+        `&query=userId%3A${userId}` +
+        `&limit=1`
+    return new Promise(async function (resolve, reject) {
         let memberInfo = []
         logger.info(`calling member api ${url} `)
-        request
-            .get(url).then((res) => {
-                if (!_.get(res, 'body.result.success')) {
-                    reject(new Error(`Failed to get member api detail for user id ${userId}`))
-                }
-                memberInfo = _.get(res, 'body.result.content')
-                logger.info(`Feteched ${memberInfo.length} record(s) from member api`)
-                resolve(memberInfo)
-            })
-            .catch((err) => {
-                reject(new Error(`Failed to get member api detail for user id ${userId}, ${err}`))
-            })
+        try {
+            const res = await request.get(url)
+            if (!_.get(res, 'body.result.success')) {
+                reject(new Error(`BCA Memeber API: Failed to get member detail for user id ${userId}`))
+            }
+            memberInfo = _.get(res, 'body.result.content')
+            logger.info(`BCA Memeber API: Feteched ${memberInfo.length} record(s) from member api`)
+            resolve(memberInfo)
+        } catch (err) {
+            reject(new Error(`BCA Memeber API: Failed to get member api detail for user id ${userId}, ${err}`))
+        }
 
     })
-    // Need clean-up 
-    /*const m2m = await getM2MToken().catch((err) => { 
-        logger.error(`${logPrefix} Failed to get m2m token`)
-        return new Promise(function(res, rej) {
-           rej(err)
-        })
+}
+
+/**
+ * Helper Function - get user group 
+ * @param {Integer} userId 
+ */
+async function getUserGroup(userId) {
+    //TODO need to take care of pagination
+    const url = config.TC_API_V5_BASE_URL +
+        `/groups/?memberId=${userId}` +
+        "&membershipType=user&page=1"
+    let groupInfo = []
+    return new Promise(async (resolve, reject) => {
+        try {
+            const machineToken = await getM2MToken()
+            //logger.info(`BCA Group API: got m2m token of length ${machineToken.length}`)
+            const res = await request.get(url).set('Authorization', `Bearer ${machineToken}`);
+            if (_.get(res, 'res.statusCode') != 200) {
+                reject(new Error(`BCA Group API: Failed to get group detail for user id ${userId}`))
+            }
+            groupInfo = _.get(res, 'body')
+            logger.info(`BCA Group API: Feteched ${groupInfo.length} record(s) from group api`)
+            resolve(groupInfo)
+        } catch (e) {
+            reject(`Calling group api ${e}`)
+        }
     })
-    logger.info(`${logPrefix} Fetched m2m token sucessfully. Token length is: `, m2m.length)
-    */
-    //return request.get(url)
 }
 
 async function checkBroadcastMessageForUser(userId, bulkMessage) {
     return new Promise(function (resolve, reject) {
-        const skills = _.get(bulkMessage, 'recipients.skills')
-        logger.info(`Got skills in DB...`, skills)
-        if (skills && skills.length > 0) {
-            try {
-                getMemberInfo(userId).then((m) => {
-                    let flag = false
-                    logger.info(`${logPrefix} got member info.`)
-                    const ms = _.get(m[0], "skills")
-                    const memberSkills = []
-                    _.map(ms, (o) => {
-                        memberSkills.push(_.get(o, 'name').toLowerCase())
-                    })
-                    logger.info(`${logPrefix} user id have following skills`, memberSkills)
-                    _.map(skills, (s) => {
-                        if (_.indexOf(memberSkills, s.toLowerCase()) >= 0) {
-                            flag = true;
-                            logger.info(`${logPrefix} '${s}' skill matached for user id ${userId}`)
-                        }
-                    })
-                    resolve({
-                        record: bulkMessage,
-                        result: flag
-                    })
-                }).catch((err) => {
-                    reject(err)
+        Promise.all([
+            checkUserSkill(userId, bulkMessage),
+            checkUserGroup(userId, bulkMessage),
+        ]).then((results) => {
+            let flag = true // TODO need to be sure about default value  
+            _.map(results, (r) => {
+                flag = !r ? false : flag // TODO recheck condition 
+            })
+            logger.info(`Final condition result is: ${flag}`)
+            resolve({
+                record: bulkMessage,
+                result: flag
+            })
+        }).catch((err) => {
+            reject(`${logPrefix} got issue in checking recipient condition. ${err}`)
+        })
+    }) // promise end
+}
+
+/**
+ *  Helper function - check Skill condition
+ */
+async function checkUserSkill(userId, bulkMessage) {
+    return new Promise(async function (resolve, reject) {
+        try {
+            const skills = _.get(bulkMessage, 'recipients.skills')
+            let flag = true // allow for all
+            if (skills && skills.length > 0) {
+                const m = await getMemberInfo(userId)
+                const ms = _.get(m[0], "skills") // get member skills 
+                const memberSkills = []
+                flag = false
+                _.map(ms, (o) => {
+                    memberSkills.push(_.get(o, 'name').toLowerCase())
+                })
+                _.map(skills, (s) => {
+                    if (_.indexOf(memberSkills, s.toLowerCase()) >= 0) {
+                        flag = true
+                        logger.info(`BroadcastMessageId: ${bulkMessage.id}, '${s}' skill matached for user id ${userId}`)
+                    }
                 })
-            } catch (err) {
-                reject(new Error(`${logPrefix} issue at skill condition check, ${err.message}`))
             }
-        } else {
-            resolve(true) // no condition on recipient, so for all 
+            resolve(flag)
+        } catch (e) {
+            reject(e)
         }
-    }) // promise end
+    }) // promise end 
+}
 
+/**
+ * Helper function - check group condition 
+ */
+async function checkUserGroup(userId, bulkMessage) {
+    return new Promise(async function (resolve, reject) {
+        try {
+            const groups = _.get(bulkMessage, 'recipients.groups')
+            let flag = true // TODO
+            if (groups.length > 0) {
+                flag = false
+                const groupInfo = await getUserGroup(userId)
+                _.map(groupInfo, (o) => {
+                    if (_.indexOf(groups, "public") >= 0) {
+                        flag = (_.get(o, "privateGroup")) ? false : flag
+                    } else {
+                        flag = (_.indexOf(groups, _.get(o, "name")) >= 0) ? true : flag
+                    }
+                })
+            }
+            resolve(flag)
+        } catch (e) {
+            reject(e)
+        }
+    })
 }
 
 module.exports = {

src/services/NotificationService.js

@@ -205,9 +205,11 @@ function* listNotifications(query, userId) {
   }
 
   if (config.ENABLE_HOOK_BULK_NOTIFICATION) {
-    yield hooks.hookBulkMessage.checkBulkMessageForUser(userId).catch((e) => {
-      logger.error(`Issue in calling bulk notification hook.`, e)
-    })
+    try {
+      yield hooks.hookBulkMessage.checkBulkMessageForUser(userId)
+    } catch (e) {
+      logger.error(`Error in calling bulk notification hook: ${e}`)
+    }
   }
 
   if (_.keys(notificationSettings).length > 0) {