Github issue#2129, Transactional emails come with a title "no-reply", but should say Topcoder

— Added environment variables to the deploy script
— Updated usage of environment in bundled email for `from` address

Author: Vikas Agarwal

connect/notificationServices/email.js

@@ -37,7 +37,7 @@ function handleScheduledEvents(events, setEventsStatus) {
     eventMessage.replyTo = config.DEFAULT_REPLY_EMAIL;
     eventMessage.cc = [];
     eventMessage.from = {
-      name: config.DEFAULT_REPLY_EMAIL,
+      name: config.REPLY_EMAIL_FROM,
       email: config.DEFAULT_REPLY_EMAIL,
     };
 
@@ -176,7 +176,7 @@ function handler(topicName, messageJSON, notification) {
         cc,
         from: {
           name: notification.contents.userHandle,
-          email: config.REPLY_EMAIL_FROM,
+          email: config.DEFAULT_REPLY_EMAIL,
         },
         categories,
       };

deploy.sh

@@ -47,6 +47,8 @@ ENABLE_EMAILS=$(eval "echo \$${ENV}_ENABLE_EMAILS")
 MENTION_EMAIL=$(eval "echo \$${ENV}_MENTION_EMAIL")
 REPLY_EMAIL_PREFIX=$(eval "echo \$${ENV}_REPLY_EMAIL_PREFIX")
 REPLY_EMAIL_DOMAIN=$(eval "echo \$${ENV}_REPLY_EMAIL_DOMAIN")
+REPLY_EMAIL_FROM=$(eval "echo \$${ENV}_REPLY_EMAIL_FROM")
+DEFAULT_REPLY_EMAIL=$(eval "echo \$${ENV}_DEFAULT_REPLY_EMAIL")
 ENABLE_DEV_MODE=$(eval "echo \$${ENV}_ENABLE_DEV_MODE")
 DEV_MODE_EMAIL=$(eval "echo \$${ENV}_DEV_MODE_EMAIL")
 
@@ -188,6 +190,14 @@ make_task_def(){
         "name": "REPLY_EMAIL_DOMAIN",
         "value": "%s"
       },
+      {
+        "name": "REPLY_EMAIL_FROM",
+        "value": "%s"
+      },
+      {
+        "name": "DEFAULT_REPLY_EMAIL",
+        "value": "%s"
+      },
       {
         "name": "ENABLE_DEV_MODE",
         "value": "%s"
@@ -251,7 +261,7 @@ make_task_def(){
   }
 ]'
 
-	task_def=$(printf "$task_template" $AWS_ECS_CONTAINER_NAME $AWS_ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $TAG $ENV "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID "$KAFKA_TOPIC_IGNORE_PREFIX" $KAFKA_URL $DATABASE_URL $AUTHSECRET $TC_API_BASE_URL $TC_API_V3_BASE_URL $TC_API_V4_BASE_URL $TC_API_V5_BASE_URL $MESSAGE_API_BASE_URL $ENABLE_EMAILS $MENTION_EMAIL $REPLY_EMAIL_PREFIX $REPLY_EMAIL_DOMAIN $ENABLE_DEV_MODE $DEV_MODE_EMAIL $LOG_LEVEL $VALID_ISSUERS $PORT "$API_CONTEXT_PATH" "$AUTH0_URL" "$AUTH0_AUDIENCE" $AUTH0_CLIENT_ID "$AUTH0_CLIENT_SECRET" $TOKEN_CACHE_TIME $AWS_ECS_CLUSTER $AWS_REGION $AWS_ECS_CLUSTER $ENV)
+	task_def=$(printf "$task_template" $AWS_ECS_CONTAINER_NAME $AWS_ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $TAG $ENV "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID "$KAFKA_TOPIC_IGNORE_PREFIX" $KAFKA_URL $DATABASE_URL $AUTHSECRET $TC_API_BASE_URL $TC_API_V3_BASE_URL $TC_API_V4_BASE_URL $TC_API_V5_BASE_URL $MESSAGE_API_BASE_URL $ENABLE_EMAILS $MENTION_EMAIL $REPLY_EMAIL_PREFIX $REPLY_EMAIL_DOMAIN $REPLY_EMAIL_FROM $DEFAULT_REPLY_EMAIL $ENABLE_DEV_MODE $DEV_MODE_EMAIL $LOG_LEVEL $VALID_ISSUERS $PORT "$API_CONTEXT_PATH" "$AUTH0_URL" "$AUTH0_AUDIENCE" $AUTH0_CLIENT_ID "$AUTH0_CLIENT_SECRET" $TOKEN_CACHE_TIME $AWS_ECS_CLUSTER $AWS_REGION $AWS_ECS_CLUSTER $ENV)
 }
 
 register_definition() {