From 1c4c4150069184092aaaf8ebcdae331ba4750677 Mon Sep 17 00:00:00 2001
From: imcaizheng <imcaizheng@gmail.com>
Date: Fri, 18 Dec 2020 07:05:19 +0800
Subject: [PATCH] throw not found error if job not exist for `GET
 /taas-teams/:id/jobs/:jobId`

---
 docs/swagger.yaml           | 6 ++++++
 src/services/TeamService.js | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/docs/swagger.yaml b/docs/swagger.yaml
index 0ccbaa43..0c0a5783 100644
--- a/docs/swagger.yaml
+++ b/docs/swagger.yaml
@@ -1473,6 +1473,12 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Error'
+        '404':
+          description: Not Found
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Error'
         '500':
           description: Internal Server Error
           content:
diff --git a/src/services/TeamService.js b/src/services/TeamService.js
index 64a3aad5..2e6551f8 100644
--- a/src/services/TeamService.js
+++ b/src/services/TeamService.js
@@ -7,6 +7,7 @@ const Joi = require('joi')
 const dateFNS = require('date-fns')
 const helper = require('../common/helper')
 const logger = require('../common/logger')
+const errors = require('../common/errors')
 const JobService = require('./JobService')
 const ResourceBookingService = require('./ResourceBookingService')
 
@@ -262,8 +263,7 @@ async function getTeamJob (currentUser, id, jobId) {
   const job = _.find(jobs, { id: jobId })
 
   if (!job) {
-    logger.debug({ component: 'TeamService', context: 'getTeamJob', message: `id ${jobId}: "Job" with Team id ${id} is not exist` })
-    return {}
+    throw new errors.NotFoundError(`id: ${jobId} "Job" with Team id ${id} doesn't exist`)
   }
   const result = {
     id: job.id,