Fix to RCRM Import script: compare endDate with today date

imcaizheng · imcaizheng · commit cb03be8a156d · 2021-02-03T19:58:22.000+08:00
diff --git a/scripts/recruit-crm-job-import/index.js b/scripts/recruit-crm-job-import/index.js
@@ -133,7 +133,7 @@ async function processJob (job, info = []) {
     data.resourceBookingId = result.id
   }
   // update the resourceBooking based on startDate and endDate
-  const resourceBookingStatus = dateFNS.compareAsc(new Date(data.startDate), new Date(data.endDate)) === 1 ? 'closed' : 'assigned'
+  const resourceBookingStatus = dateFNS.isBefore(data.endDate, dateFNS.startOfToday()) ? 'closed' : 'assigned'
   logger.debug(`resourceBookingId: ${data.resourceBookingId} status: ${resourceBookingStatus}`)
   await helper.updateResourceBookingStatus(data.resourceBookingId, resourceBookingStatus)
   info.push({ text: `id: ${data.resourceBookingId} status: ${resourceBookingStatus} resource booking updated`, tag: 'resource_booking_status_updated' })

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ async function processJob (job, info = []) {`
`133`	`133`	`data.resourceBookingId = result.id`
`134`	`134`	`}`
`135`	`135`	`// update the resourceBooking based on startDate and endDate`
`136`		`- const resourceBookingStatus = dateFNS.compareAsc(new Date(data.startDate), new Date(data.endDate)) === 1 ? 'closed' : 'assigned'`
	`136`	`+ const resourceBookingStatus = dateFNS.isBefore(data.endDate, dateFNS.startOfToday()) ? 'closed' : 'assigned'`
`137`	`137`	logger.debug(`resourceBookingId: ${data.resourceBookingId} status: ${resourceBookingStatus}`)
`138`	`138`	`await helper.updateResourceBookingStatus(data.resourceBookingId, resourceBookingStatus)`
`139`	`139`	info.push({ text: `id: ${data.resourceBookingId} status: ${resourceBookingStatus} resource booking updated`, tag: 'resource_booking_status_updated' })