fix: issue #475

Author: yoution

app-constants.js

@@ -9,8 +9,6 @@ const UserRoles = {
   TopcoderUser: 'Topcoder User'
 }
 
-const TopCoderUserPermissionRole = UserRoles.TopcoderUser
-
 const FullManagePermissionRoles = [
   UserRoles.BookingManager,
   UserRoles.Administrator
@@ -165,7 +163,6 @@ const JobCandidateStatus = {
 
 module.exports = {
   UserRoles,
-  TopCoderUserPermissionRole,
   FullManagePermissionRoles,
   Scopes,
   Interviews,

src/common/helper.js

@@ -1073,15 +1073,6 @@ async function getTopcoderUserById (userId) {
   return user
 }
 
-/**
- * Function to download resume
- * @param {String} resumeUrl the resume id
- * @returns the request result
- */
-async function downloadResume (resumeUrl) {
-  return request.get(resumeUrl)
-}
-
 /**
  * Function to get users
  * @param {String} userId the user id
@@ -2073,7 +2064,6 @@ module.exports = {
     }
     return ensureUbahnUserId({ userId })
   },
-  downloadResume,
   getUserByExternalId,
   getM2MToken,
   getM2MUbahnToken,

src/controllers/JobCandidateController.js

@@ -69,12 +69,9 @@ async function searchJobCandidates (req, res) {
  * @param req the request
  * @param res the response
  */
-async function downlaodJobCandidateResume (req, res) {
-  const { body, res: { headers } } = await service.downlaodJobCandidateResume(req.authUser, req.params.id)
-  for (const h in headers) {
-    res.setHeader(h, headers[h])
-  }
-  res.send(body)
+async function downloadJobCandidateResume (req, res) {
+  const resumeUrl = await service.downloadJobCandidateResume(req.authUser, req.params.id)
+  res.redirect(resumeUrl)
 }
 
 module.exports = {
@@ -84,5 +81,5 @@ module.exports = {
   fullyUpdateJobCandidate,
   deleteJobCandidate,
   searchJobCandidates,
-  downlaodJobCandidateResume
+  downloadJobCandidateResume
 }

src/routes/JobCandidateRoutes.js

@@ -47,7 +47,7 @@ module.exports = {
   '/jobCandidates/:id/resume': {
     get: {
       controller: 'JobCandidateController',
-      method: 'downlaodJobCandidateResume',
+      method: 'downloadJobCandidateResume',
       auth: 'jwt',
       scopes: [constants.Scopes.READ_JOB_CANDIDATE, constants.Scopes.ALL_JOB_CANDIDATE]
     }

src/services/JobCandidateService.js

@@ -8,7 +8,7 @@ const config = require('config')
 const HttpStatus = require('http-status-codes')
 const { Op } = require('sequelize')
 const { v4: uuid } = require('uuid')
-const { Scopes, TopCoderUserPermissionRole } = require('../../app-constants')
+const { Scopes, UserRoles } = require('../../app-constants')
 const helper = require('../common/helper')
 const logger = require('../common/logger')
 const errors = require('../common/errors')
@@ -365,35 +365,40 @@ searchJobCandidates.schema = Joi.object().keys({
  * @params {Object} currentUser the user who perform this operation
  * @params {String} id the jobCandidate id
  */
-async function downlaodJobCandidateResume (currentUser, id) {
+async function downloadJobCandidateResume (currentUser, id) {
   const jobCandidate = await JobCandidate.findById(id)
   const { id: currentUserUserId } = await helper.getUserByExternalId(currentUser.userId)
 
   // customer role
-  if (!jobCandidate.viewedByCustomer && currentUserUserId !== jobCandidate.userId && currentUser.roles.length === 1 && currentUser.roles[0] === TopCoderUserPermissionRole) {
-    const job = await models.Job.findById(jobCandidate.jobId)
-    const { handle } = await helper.getUserById(jobCandidate.userId, true)
-    const { email } = await helper.getMemberDetailsByHandle(handle)
-
-    await EmailNotificationService.sendEmail(currentUser, {
-      template: 'taas.notification.job-candidate-resume-viewed',
-      recipients: [email],
-      data: {
-        jobCandidateUserHandle: handle,
-        jobName: job.title,
-        notificationType: {
-          jobCandidateResumeViewed: true
+  if (!jobCandidate.viewedByCustomer && currentUserUserId !== jobCandidate.userId && currentUser.roles.length === 1 && currentUser.roles[0] === UserRoles.TopcoderUser) {
+    try {
+      const job = await models.Job.findById(jobCandidate.jobId)
+      const { handle } = await helper.getUserById(jobCandidate.userId, true)
+      const { email } = await helper.getMemberDetailsByHandle(handle)
+
+      await EmailNotificationService.sendEmail(currentUser, {
+        template: 'taas.notification.job-candidate-resume-viewed',
+        recipients: [email],
+        data: {
+          jobCandidateUserHandle: handle,
+          jobName: job.title,
+          description: 'Client Viewed Resume',
+          notificationType: {
+            jobCandidateResumeViewed: true
+          }
         }
-      }
-    })
+      })
 
-    await updateJobCandidate(currentUser, jobCandidate.id, { viewedByCustomer: true })
+      await updateJobCandidate(currentUser, jobCandidate.id, { viewedByCustomer: true })
+    } catch (err) {
+      logger.logFullError(err, { component: 'JobCandidateService', context: 'downloadJobCandidateResume' })
+    }
   }
 
-  return helper.downloadResume(jobCandidate.resume)
+  return jobCandidate.resume
 }
 
-downlaodJobCandidateResume.schema = Joi.object().keys({
+downloadJobCandidateResume.schema = Joi.object().keys({
   currentUser: Joi.object().required(),
   id: Joi.string().uuid().required()
 }).required()
@@ -405,5 +410,5 @@ module.exports = {
   fullyUpdateJobCandidate,
   deleteJobCandidate,
   searchJobCandidates,
-  downlaodJobCandidateResume
+  downloadJobCandidateResume 
 }