Interview changes from, recipients, & cc

Author: urwithat

config/default.js

@@ -144,16 +144,18 @@ module.exports = {
   REQUEST_EXTENSION_EMAILS: (process.env.REQUEST_EXTENSION_EMAILS || '').split(','),
   // the emails address for interview invitation
   // INTERVIEW_INVITATION_CC_LIST may contain comma-separated list of email which is converted to array
-  // scheduler@x.ai should be in the CC list
-  INTERVIEW_INVITATION_CC_LIST: (process.env.INTERVIEW_INVITATION_CC_LIST || 'scheduler@x.ai').split(','),
+  INTERVIEW_INVITATION_CC_LIST: (process.env.INTERVIEW_INVITATION_CC_LIST || '').split(','),
+  // INTERVIEW_INVITATION_RECIPIENTS_LIST may contain comma-separated list of email which is converted to array
+  // scheduler@x.ai should be in the RECIPIENTS list
+  INTERVIEW_INVITATION_RECIPIENTS_LIST: (process.env.INTERVIEW_INVITATION_RECIPIENTS_LIST || 'scheduler@topcoder.com').split(','),
   // SendGrid email template ID for reporting issue
   REPORT_ISSUE_SENDGRID_TEMPLATE_ID: process.env.REPORT_ISSUE_SENDGRID_TEMPLATE_ID,
   // SendGrid email template ID for requesting extension
   REQUEST_EXTENSION_SENDGRID_TEMPLATE_ID: process.env.REQUEST_EXTENSION_SENDGRID_TEMPLATE_ID,
   // SendGrid email template ID for interview invitation
   INTERVIEW_INVITATION_SENDGRID_TEMPLATE_ID: process.env.INTERVIEW_INVITATION_SENDGRID_TEMPLATE_ID,
   // The sender (aka `from`) email for invitation.
-  INTERVIEW_INVITATION_SENDER_EMAIL: process.env.INTERVIEW_INVITATION_SENDER_EMAIL || 'scheduler@topcoder.com',
+  INTERVIEW_INVITATION_SENDER_EMAIL: process.env.INTERVIEW_INVITATION_SENDER_EMAIL || 'talent@topcoder.com',
   // the URL where TaaS App is hosted
   TAAS_APP_URL: process.env.TAAS_APP_URL || 'https://platform.topcoder-dev.com/taas/myteams',
   // environment variables for Payment Service

config/email_template.config.js

@@ -96,6 +96,7 @@ module.exports = {
   'interview-invitation': {
     from: config.INTERVIEW_INVITATION_SENDER_EMAIL,
     cc: config.INTERVIEW_INVITATION_CC_LIST,
+    recipients: config.INTERVIEW_INVITATION_RECIPIENTS_LIST,
     sendgridTemplateId: config.INTERVIEW_INVITATION_SENDGRID_TEMPLATE_ID
   }
 }

src/eventHandlers/InterviewEventHandler.js

@@ -20,29 +20,12 @@ async function sendInvitationEmail (payload) {
   // get job candidate user details
   const jobCandidate = await models.JobCandidate.findById(interview.jobCandidateId)
   const jobCandidateUser = await helper.getUserById(jobCandidate.userId, true)
-  // const jobCandidateUserEmail = helper.getUserAttributeValue(jobCandidateUser, 'email')
   // get customer details
   const job = await jobCandidate.getJob()
-  // const customerUser = await helper.getUserByExternalId(job.externalId, true)
-  // const customerUserEmail = helper.getUserAttributeValue(customerUser, 'email')
-
-  // TODO: remove mock addresses & switch back to the old implementation once API gets fixed
-  // Both emails will be undefined since TC API doesn't return attributes,
-  // this is a workaround to skip check/condition & log the payload
-  // it will post the event nevertheless (with mocked candidate&customer address), so you can see on the logs as kafka event
-  // and verify the payload content
-  const customerMockEmail = 'testcustomer@yopmail.com'
-  const candidateMockEmail = 'testuserforemail@yopmail.com'
-
-  // if (jobCandidateUserEmail && customerUserEmail) {
   const interviewerList = interview.attendeesList
-    // ? [customerUserEmail, ...interview.attendeesList].join(', ') // "customer@mail.com, first@attendee.com, second@attendee.com..."
-    // : customerUserEmail
-    ? [customerMockEmail, ...interview.attendeesList].join(', ') // "customer@mail.com, first@attendee.com, second@attendee.com..."
-    : customerMockEmail
+
   teamService.sendEmail({}, {
     template: 'interview-invitation',
-    recipients: [candidateMockEmail, customerMockEmail],
     cc: interview.attendeesList,
     data: {
       interviewType: interview.xaiTemplate,
@@ -54,16 +37,6 @@ async function sendInvitationEmail (payload) {
       candidateId: interview.jobCandidateId
     }
   })
-  /* } else {
-    // one (or both) of the emails are missing due to some reason
-    // for e.g. some users' externalIds may be set to null or similar
-    // log error
-    logger.error({
-      component: 'InterviewEventHandler',
-      context: 'sendInvitationEmail',
-      message: 'Couldn\'t sent invitation emails. Insufficient details.'
-    })
-  } */
 }
 
 /**