fix(interview-scheduler): await getJob promise

cagdas001 · cagdas001 · commit 0611e65d6322 · 2021-04-30T19:29:30.000+03:00
Fix an issue, which was causing getting `undefined` as jobProjectId. This was causing unexpected behaviors when checking the project-based user access level. Addresses topcoder-archive/topcoder-platform-taas-app#173 (comment)
diff --git a/src/services/InterviewService.js b/src/services/InterviewService.js
@@ -26,7 +26,7 @@ const esClient = helper.getESClient()
 async function ensureUserIsPermitted (currentUser, jobCandidateId) {
   if (!currentUser.hasManagePermission && !currentUser.isMachine) {
     const jobCandidate = await models.JobCandidate.findById(jobCandidateId)
-    const job = jobCandidate.getJob()
+    const job = await jobCandidate.getJob()
     await helper.checkIsMemberOfProject(currentUser.userId, job.projectId)
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ const esClient = helper.getESClient()`
`26`	`26`	`async function ensureUserIsPermitted (currentUser, jobCandidateId) {`
`27`	`27`	`if (!currentUser.hasManagePermission && !currentUser.isMachine) {`
`28`	`28`	`const jobCandidate = await models.JobCandidate.findById(jobCandidateId)`
`29`		`- const job = jobCandidate.getJob()`
	`29`	`+ const job = await jobCandidate.getJob()`
`30`	`30`	`await helper.checkIsMemberOfProject(currentUser.userId, job.projectId)`
`31`	`31`	`}`
`32`	`32`	`}`