fix: wip memberid out of scope error

Author: hamidre13

.npmrc

@@ -61,7 +61,7 @@ module.exports = {
     "9ecc88e5-a4ee-44a4-8ec1-70bd98022510": 123789456,
     "d6d31f34-8ee5-4589-ae65-45652fcc01a6": 30000720,
   },
-  GRPC_CHALLENGE_SERVER_HOST:
-    process.env.GRPC_CHALLENGE_SERVER_HOST || "localhost",
-  GRPC_CHALLENGE_SERVER_PORT: process.env.GRPC_CHALLENGE_SERVER_PORT || 9092,
+  GRPC_SUBMISSION_SERVER_HOST:
+    process.env.GRPC_SUBMISSION_SERVER_HOST || "localhost",
+  GRPC_SUBMISSION_SERVER_PORT: process.env.GRPC_SUBMISSION_SERVER_PORT || 9092,
 };

config/default.js

@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@elastic/elasticsearch": "^8.6.0",
-    "@topcoder-framework/domain-submission": "^v0.4.18-ci.0",
+    "@topcoder-framework/domain-submission": "0.5.4-ci.0",
     "@topcoder-framework/lib-common": "^v0.4.18-ci.0",
     "amazon-s3-uri": "0.0.3",
     "aws-sdk": "^2.265.1",

package.json

@@ -24,8 +24,8 @@ const {
 const { SubmissionDomain } = require("@topcoder-framework/domain-submission");
 
 const submissionDomain = new SubmissionDomain(
-  config.GRPC_CHALLENGE_SERVER_HOST,
-  config.GRPC_CHALLENGE_SERVER_PORT
+  config.GRPC_SUBMISSION_SERVER_HOST,
+  config.GRPC_SUBMISSION_SERVER_PORT
 );
 
 const table = "Submission";
@@ -361,24 +361,19 @@ async function createSubmission(authUser, files, entity) {
 
   // Submission api only works with legacy challenge id
   // If it is a v5 challenge id, get the associated legacy challenge id
+  //TODO: move this to domain layer
   const challengeId = await helper.getV5ChallengeId(entity.challengeId);
   const legacyChallengeId = await helper.getLegacyChallengeId(
     entity.challengeId
   );
   const currDate = new Date().getTime();
 
   const item = {
-    id: submissionId,
     challengeId,
-    createdBy: authUser.handle || authUser.sub,
-    fileType: "",
-    memberId: entity.memberId,
-    submittedDate: currDate,
+    fileType: entity.fileType || fileType,
     type: entity.type,
-    updatedBy: authUser.handle || authUser.sub,
+    // memberId: +entity.memberId,
     url: url,
-    created: currDate,
-    updated: currDate,
   };
 
   // Pure v5 challenges won't have a legacy challenge id
@@ -429,8 +424,8 @@ async function createSubmission(authUser, files, entity) {
     );
   }
 
-  item.submittedDate = new Date(entity.submittedDate || item.created).getTime();
-  item.createdBy = entity.createdBy || "";
+  // item.submittedDate = new Date(entity.submittedDate || item.created).getTime();
+  // item.createdBy = entity.createdBy || "";
 
   if (!item.submissionPhaseId) {
     delete item.submissionPhaseId;

src/services/SubmissionService.js

@@ -473,16 +473,26 @@
   resolved "http://localhost:4873/@tootallnate%2fonce/-/once-1.1.2.tgz#ccb91445360179a04e7fe6aff78c00ffc1eeaf82"
   integrity sha512-RbzJvlNzmRq5c3O09UipeuXno4tA1FE6ikOjxZK0tuxVv3412l64l5t1W5pj4+rJq9vpkm/kwiR07aZXnsKPxw==
 
-"@topcoder-framework/domain-submission@^v0.4.18-ci.0":
-  version "0.4.18-ci.0"
-  resolved "http://localhost:4873/@topcoder-framework%2fdomain-submission/-/domain-submission-0.4.18-ci.0.tgz#91005f80e26fad6a62e2fc206a19e052f544f101"
-  integrity sha512-laav/vrkWxY/2DxNX78rXrh8hnlhRrwurw3OujfOIbqLFvK8+/xrVCic1zDoBsete3eU8UeeLBqFU1xJNFQHhQ==
+"@topcoder-framework/domain-submission@0.5.4-ci.0":
+  version "0.5.4-ci.0"
+  resolved "https://topcoder-409275337247.d.codeartifact.us-east-1.amazonaws.com:443/npm/topcoder-framework/@topcoder-framework/domain-submission/-/domain-submission-0.5.4-ci.0.tgz#37464c4aefdfc9eb20a5a2d04cf0e70913a16968"
+  integrity sha512-nL84kUE2+gDQzrEK6/AnMre2O9JQAOh/CcvnlHilMAfvZGvwoHelNyJV4EXkn7hXv7a8fYDTJKTfXd5cB7QI6g==
   dependencies:
-    "@topcoder-framework/lib-common" "^0.2.1"
+    "@topcoder-framework/lib-common" "0.5.4-ci.0"
     dotenv "^16.0.3"
     tslib "^2.4.1"
 
-"@topcoder-framework/lib-common@^0.2.1", "@topcoder-framework/lib-common@^v0.4.18-ci.0":
+"@topcoder-framework/lib-common@0.5.4-ci.0":
+  version "0.5.4-ci.0"
+  resolved "https://topcoder-409275337247.d.codeartifact.us-east-1.amazonaws.com:443/npm/topcoder-framework/@topcoder-framework/lib-common/-/lib-common-0.5.4-ci.0.tgz#e0ed57df5dd0a2efdbac484749c2e3fd06808105"
+  integrity sha512-ikgnb6DYDUP3wGzmGB9bvATllw7RsLJzoYO0H2QHiBKBe5yyjS5t9S9BzqV8dyTlSekg4B9nhwiYY9X1Z4kwaQ==
+  dependencies:
+    "@grpc/grpc-js" "^1.8.0"
+    rimraf "^3.0.2"
+    topcoder-interface "github:topcoder-platform/plat-interface-definition#v0.0.20"
+    tslib "^2.4.1"
+
+"@topcoder-framework/lib-common@^v0.4.18-ci.0":
   version "0.4.18-ci.0"
   resolved "http://localhost:4873/@topcoder-framework%2flib-common/-/lib-common-0.4.18-ci.0.tgz#aa2cfad142fc6507035a405585b61a8c3c00a2d1"
   integrity sha512-yE3xAjWU1/MZYuJn8QT8/iepkMjH5T9/Ctyim1alHae/OP5l9RkpidZVuLdxm8MXHQDmERWCzNWn/O1YLuwBgw==
@@ -6732,6 +6742,10 @@ toidentifier@1.0.1:
   version "1.0.0"
   resolved "https://codeload.github.com/topcoder-platform/plat-interface-definition/tar.gz/83db3ad5ac053393f8d9aa975dfe067fd8942add"
 
+"topcoder-interface@github:topcoder-platform/plat-interface-definition#v0.0.20":
+  version "1.0.0"
+  resolved "https://codeload.github.com/topcoder-platform/plat-interface-definition/tar.gz/7f80c4abb46660eb5cff15dfd57b4515b7d49870"
+
 topo@3.x.x:
   version "3.0.3"
   resolved "http://localhost:4873/topo/-/topo-3.0.3.tgz#d5a67fb2e69307ebeeb08402ec2a2a6f5f7ad95c"