Skip to content

Commit d227c8d

Browse files
committed
memberId comparison should be a number always
1 parent 5704db5 commit d227c8d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/services/ResourceService.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ async function createResource (currentUser, resource) {
214214
}
215215

216216
if (_.reduce(resources,
217-
(result, r) => r.memberId === memberId && r.roleId === resource.roleId ? true : result,
217+
(result, r) => _.toNumber(r.memberId) === _.toNumber(memberId) && r.roleId === resource.roleId ? true : result,
218218
false)) {
219219
throw new errors.ConflictError(`User ${resource.memberHandle} already has resource with roleId: ${resource.roleId} in challenge: ${challengeId}`)
220220
}
@@ -263,7 +263,7 @@ async function deleteResource (currentUser, resource) {
263263
const { resources, memberId, handle } = await init(currentUser, challengeId, resource)
264264

265265
const ret = _.reduce(resources,
266-
(result, r) => r.memberId === memberId && r.roleId === resource.roleId ? r : result,
266+
(result, r) => _.toNumber(r.memberId) === _.toNumber(memberId) && r.roleId === resource.roleId ? r : result,
267267
undefined)
268268

269269
if (!ret) {

0 commit comments

Comments
 (0)