Skip to content

Commit 2dda7e3

Browse files
fix default values for sorting resources
1 parent 4fb68f4 commit 2dda7e3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/services/ResourceService.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ async function checkAccess (currentUser, resources) {
4747
async function getResources (currentUser, challengeId, roleId, page, perPage, sortBy, sortOrder) {
4848
page = page || 1
4949
perPage = perPage || config.DEFAULT_PAGE_SIZE
50+
sortBy = sortBy || 'created'
51+
sortOrder = sortOrder || 'asc'
5052
if (!validateUUID(challengeId)) {
5153
throw new errors.BadRequestError(`Challenge ID ${challengeId} must be a valid v5 Challenge Id (UUID)`)
5254
}
@@ -182,8 +184,7 @@ getResources.schema = {
182184
roleId: Joi.optionalId(),
183185
page: Joi.page().default(1),
184186
perPage: Joi.perPage().default(config.DEFAULT_PAGE_SIZE),
185-
// sortBy: Joi.string().valid('memberHandle', 'created').default('created'), // have to reindex to sort by memberHandle
186-
sortBy: Joi.string().valid('created').default('created'),
187+
sortBy: Joi.string().valid('memberHandle', 'created').default('created'),
187188
sortOrder: Joi.string().valid('desc', 'asc').default('asc')
188189
}
189190

0 commit comments

Comments
 (0)