fix: unit tests for productCategories

This test failed after the fixing of expectObj() method.

Author: maxceem

src/services/ProcessorServiceProductCategory.js

@@ -76,7 +76,7 @@ async function create (message) {
   }
 
   await helper.updateMetadadaESPromise(updateDocPromise)
-  logger.debug(`Product category created successfully in elasticsearch index, (productCategoryId: ${message.key})`)
+  logger.debug(`Product category created successfully in elasticsearch index, (productCategoryKey: ${message.key})`)
 }
 
 create.schema = {
@@ -102,7 +102,7 @@ async function update (message) {
   }
 
   await helper.updateMetadadaESPromise(updateDocPromise)
-  logger.debug(`Product category updated successfully in elasticsearch index, (productCategoryId: ${message.key})`)
+  logger.debug(`Product category updated successfully in elasticsearch index, (productCategoryKey: ${message.key})`)
 }
 
 update.schema = {
@@ -122,7 +122,7 @@ async function deleteMessage (message) {
   }
 
   await helper.updateMetadadaESPromise(updateDocPromise)
-  logger.debug(`Product category deleted successfully in elasticsearch index, (productCategoryId: ${message.key})`)
+  logger.debug(`Product category deleted successfully in elasticsearch index, (productCategoryKey: ${message.key})`)
 }
 
 deleteMessage.schema = {

test/common/testData.js

@@ -136,8 +136,8 @@ const orgConfigId = orgConfigCreatedMessage.payload.id
 const projectTemplateId = projectTemplateCreatedMessage.payload.id
 const projectTypeId = projectTypeCreatedMessage.payload.key
 const projectTypeNotFoundId = `${projectTypeCreatedMessage.payload.key}_notFound`
-const productCategoryId = productCategoryCreatedMessage.payload.id
-const productCategoryNotFoundId = `${productCategoryCreatedMessage.payload.key}_notFound`
+const productCategoryKey = productCategoryCreatedMessage.payload.key
+const productCategoryNotFoundKey = `${productCategoryCreatedMessage.payload.key}_notFound`
 const metadataId = config.get('esConfig.ES_METADATA_DEFAULT_ID')
 let notFoundId = getRandomInt(10000000)
 // we use projectId+1, timelineId+1, attachmentId+1,... to create another object if need
@@ -186,8 +186,8 @@ module.exports = {
   projectTemplateId,
   projectTypeId,
   projectTypeNotFoundId,
-  productCategoryId,
-  productCategoryNotFoundId,
+  productCategoryKey,
+  productCategoryNotFoundKey,
   productCategoryUpdatedMessage,
   productCategoryCreatedMessage,
   productCategoryDeletedMessage,

test/e2e/processor.metadata.index.test.js

@@ -25,8 +25,8 @@ const {
   projectTemplateId,
   projectTypeId,
   projectTypeNotFoundId,
-  productCategoryId,
-  productCategoryNotFoundId,
+  productCategoryKey,
+  productCategoryNotFoundKey,
   productCategoryUpdatedMessage,
   productCategoryCreatedMessage,
   productCategoryDeletedMessage,
@@ -106,39 +106,39 @@ describe('TC Product Category Topic Tests', () => {
   it('create product category message', async () => {
     await ProcessorService.create(productCategoryCreatedMessage)
     const data = await testHelper.getMetadataESData(metadataId)
-    testHelper.expectObj(_.find(data.productCategories, { key: productCategoryId }),
+    testHelper.expectObj(_.find(data.productCategories, { key: productCategoryKey }),
       productCategoryCreatedMessage.payload,
       _.keys(_.omit(productCategoryCreatedMessage.payload, ['resource'])))
   })
 
   it('create product category message - already exists', async () => {
     await ProcessorService.create(productCategoryCreatedMessage)
     const data = await testHelper.getMetadataESData(metadataId)
-    testHelper.expectObj(_.find(data.productCategories, { key: productCategoryId }),
+    testHelper.expectObj(_.find(data.productCategories, { key: productCategoryKey }),
       productCategoryCreatedMessage.payload,
       _.keys(_.omit(productCategoryCreatedMessage.payload, ['resource'])))
   })
 
   it('update product category message', async () => {
     await ProcessorService.update(productCategoryUpdatedMessage)
     const data = await testHelper.getMetadataESData(metadataId)
-    testHelper.expectObj(_.find(data.productCategories, { key: productCategoryId }),
+    testHelper.expectObj(_.find(data.productCategories, { key: productCategoryKey }),
       productCategoryUpdatedMessage.payload,
       _.keys(_.omit(productCategoryUpdatedMessage.payload, ['resource'])))
   })
 
   it('update product category message - not found', async () => {
     const message = _.cloneDeep(productCategoryUpdatedMessage)
-    message.payload.key = productCategoryNotFoundId
+    message.payload.key = productCategoryNotFoundKey
     await ProcessorService.update(message)
     const data = await testHelper.getMetadataESData(metadataId)
-    expect(_.find(data.productCategories, { key: productCategoryNotFoundId })).to.be.an('undefined')
+    expect(_.find(data.productCategories, { key: productCategoryNotFoundKey })).to.be.an('undefined')
   })
 
   it('delete product category message', async () => {
     await ProcessorService.deleteMessage(productCategoryDeletedMessage)
     const data = await testHelper.getMetadataESData(metadataId)
-    expect(_.find(data.productCategories, { key: productCategoryId })).to.be.an('undefined')
+    expect(_.find(data.productCategories, { key: productCategoryKey })).to.be.an('undefined')
   })
 })