Fix issue 29, Throw error if no invite has been removed when it should.

Author: narekcat

src/services/ProcessorServiceProjectMemberInvite.js

@@ -57,8 +57,11 @@ create.schema = {
 const updateInvitesPromise = message => async (doc) => {
   // now merge the updated changes and re-index the document
   const invites = _.isArray(doc._source.invites) ? doc._source.invites : []
-  _.remove(invites, invite => (!!message.email && invite.email === message.email) ||
+  const removedInvites = _.remove(invites, invite => (!!message.email && invite.email === message.email) ||
   (!!message.userId && invite.userId === message.userId))
+  if (invites.length && !removedInvites.length) {
+    throw new Error(`Invite with email "${message.email}" and userId "${message.userId}" is not found and not removed.`)
+  }
   return _.assign(doc._source, { invites })
 }
 

test/e2e/processor.project.index.test.js

@@ -892,6 +892,24 @@ describe('TC Project Member Invite Topic Tests', () => {
     expect(_.find(data.invites, { id: notFoundId })).to.be.an('undefined')
   })
 
+  it('update project member invite message - invalid parameters, not existing member', async () => {
+    const message = _.cloneDeep(projectMemberInviteUpdatedMessage)
+    message.payload.userId = '11111111'
+    message.payload.email = 'wrong@mail.com'
+    try {
+      await ProcessorService.create(projectMemberInviteCreatedMessage)
+      await ProcessorService.update(message)
+    } catch (err) {
+      logger.logFullError(err)
+      expect(err).to.exist // eslint-disable-line
+      expect(err.name).to.equal('Error')
+      const msg = 'not found and not removed.'
+      expect(err.message.indexOf(msg) >= 0).to.equal(true)
+      return
+    }
+    throw new Error('There should be not found error.')
+  })
+
   it('delete project member invite message', async () => {
     await ProcessorService.create(projectMemberInviteCreatedMessage)
     let data = await testHelper.getProjectESData(projectId)
@@ -910,6 +928,24 @@ describe('TC Project Member Invite Topic Tests', () => {
     expect(_.find(data.invites, { id: notFoundId })).to.be.an('undefined')
   })
 
+  it('delete project member invite message - invalid parameters, not existing member', async () => {
+    const message = _.cloneDeep(projectMemberInviteDeletedMessage)
+    message.payload.userId = '11111111'
+    message.payload.email = 'wrong@mail.com'
+    try {
+      await ProcessorService.create(projectMemberInviteCreatedMessage)
+      await ProcessorService.deleteMessage(message)
+    } catch (err) {
+      logger.logFullError(err)
+      expect(err).to.exist // eslint-disable-line
+      expect(err.name).to.equal('Error')
+      const msg = 'not found and not removed.'
+      expect(err.message.indexOf(msg) >= 0).to.equal(true)
+      return
+    }
+    throw new Error('There should be not found error.')
+  })
+
   it('test logger', async () => {
     /**
      * test long array