refactor: stress test code enhancements

Author: maxceem

config/default.js

@@ -37,6 +37,7 @@ module.exports = {
     ES_METADATA_DEFAULT_ID: process.env.ES_METADATA_DEFAULT_ID || 1 // use for setting default id of metadata
   },
 
+  // configuration for the stress test, see `test/stress/README.md`
   STRESS_BASIC_QTY: process.env.STRESS_BASIC_QTY || 100,
   STRESS_TESTER_TIMEOUT: process.env.STRESS_TESTER_TIMEOUT || 80
 }

package.json

@@ -11,7 +11,7 @@
     "view-data": "node test/common/view-data.js",
     "test": "NODE_ENV=test npm run sync:es && mocha test/e2e/*.test.js --timeout 30000 --exit && NODE_ENV=test npm run sync:es",
     "test:cov": "nyc --reporter=html --reporter=text npm test",
-    "test:stress": "npm run sync:es && node test/stress/doTest.js"
+    "test:stress": "NODE_ENV=test npm run sync:es && NODE_ENV=test node test/stress/doTest.js"
   },
   "author": "TCSCODER",
   "license": "none",

src/services/ProcessorServiceMilestone.js

@@ -88,14 +88,8 @@ async function create (message) {
     return _.assign(doc._source, { milestones })
   }
 
-  // NOTE Disable indexing milestones when create at the moment, as it's now being indexed inside Project Service.
-  //      It's because adding a milestones may cause cascading updates of other milestones and in such cases we are doing
-  //      one ES index call instead of multiple calls. Otherwise ES may fail with error `version conflict`.
-  //      This would be turned on back, as soon as we get rid of such cascading updates inside Project Service.
-  //
   await helper.updateTimelineESPromise(message.timelineId, updateDocPromise)
   logger.debug(`Milestone created successfully in elasticsearch index, (milestoneId: ${message.id})`)
-  // logger.debug(`TEMPORARY SKIPPED: Milestone created successfully in elasticsearch index, (milestoneId: ${message.id})`)
 }
 
 create.schema = {
@@ -119,14 +113,8 @@ async function update (message) {
     return _.assign(doc._source, { milestones })
   }
 
-  // NOTE Disable indexing milestones when update at the moment, as it's now being indexed inside Project Service.
-  //      It's because updating a milestones may cause cascading updates of other milestones and in such cases we are doing
-  //      one ES index call instead of multiple calls. Otherwise ES may fail with error `version conflict`.
-  //      This would be turned on back, as soon as we get rid of such cascading updates inside Project Service.
-  //
   await helper.updateTimelineESPromise(message.timelineId, updateDocPromise)
   logger.debug(`Milestone updated successfully in elasticsearch index, (milestoneId: ${message.id})`)
-  // logger.debug(`TEMPORARY SKIPPED: Milestone updated successfully in elasticsearch index, (milestoneId: ${message.id})`)
 }
 
 update.schema = {

src/services/ProcessorServiceProject.js

@@ -47,7 +47,7 @@ function createSchema () {
       createdAt: Joi.date(),
       createdBy: Joi.number().integer().positive(),
       updatedAt: Joi.date(),
-      updatedBy: Joi.number().integer().positive(),
+      updatedBy: Joi.number().integer().positive()
     })).optional().allow(null),
     external: Joi.object().keys({
       id: Joi.string(),

test/stress/README.md

@@ -1,17 +1,25 @@
 ## Configuration
 
-* STRESS_BASIC_QTY: As requested in challenge description
+* `STRESS_BASIC_QTY`: As requested in challenge description
 
-* STRESS_TESTER_TIMEOUT: Number of seconds to wait after queueing create/update/delete requests
-and before validating data. Default is 80s, which is enough for `STRESS_BASIC_QTY=100`. This
-might have to be increased if `STRESS_BASIC_QTY` is higher than 100.
+* `STRESS_TESTER_TIMEOUT`: Number of seconds to wait after queueing create/update/delete requests and before validating data. Default is 80s, which is enough for `STRESS_BASIC_QTY=100`. This might have to be increased if `STRESS_BASIC_QTY` is higher than 100.
 
-## Validation
+## Run
 
-* Start processor:
+* Start processor
 
-    npm start
+  It should point the **test** ES, so set `NODE_ENV=test`.
 
-* Run `npm run test:stress`
+   ```
+   NODE_ENV=test npm start
+   ```
 
-Saves ids of milestones not updated/created/deleted to `test/stress/stress_test_errors.json`
+* Run stress test
+
+  It would test using **test** ES, as this command sets `NODE_ENV=test`.
+
+  ```
+  npm run test:stress
+  ```
+
+I would save ids of milestones not updated/created/deleted to `test/stress/stress_test_errors.json`