From 5d9d5a8db7f895a23f66e07918bca37d5d0bb3bc Mon Sep 17 00:00:00 2001 From: Brooke Date: Mon, 7 Nov 2022 13:42:50 -0800 Subject: [PATCH] TCA-645 #comment This commit fixes all eslint issues that are auto-fixable #time 10m --- src-ts/header/Header.tsx | 24 +- .../header/tool-selectors/ToolSelectors.tsx | 4 +- .../tool-selector-wide/ToolSelectorWide.tsx | 2 +- .../utility-selectors/UtilitySelectors.tsx | 14 +- src-ts/index.ts | 32 +- src-ts/lib/analytics/Analytics.tsx | 15 +- .../breadcrumb-item/BreadcrumbItem.tsx | 18 +- .../ContactSupportForm.tsx | 8 +- src-ts/lib/content-layout/ContentLayout.tsx | 50 ++- src-ts/lib/form/Form.tsx | 58 ++-- .../lib/form/form-functions/form.functions.ts | 6 +- src-ts/lib/form/form-groups/FormGroups.tsx | 20 +- .../form-groups/form-card-set/FormCardSet.tsx | 30 +- .../form-group-item/FormGroupItem.tsx | 82 +++-- .../form-input-row/FormInputRow.tsx | 2 +- .../input-file-picker/InputFilePicker.tsx | 2 +- .../input-image-picker/InputImagePicker.tsx | 7 +- .../form-input/input-rating/InputRating.tsx | 4 +- .../form-input/input-select/InputSelect.tsx | 2 +- .../input-textarea/InputTextarea.tsx | 46 ++- .../lib/form/form-groups/form-radio/index.tsx | 10 +- src-ts/lib/form/validator-functions/index.ts | 2 +- .../validator.functions.ts | 4 +- .../authentication-url.config.ts | 2 +- .../file-functions/file.functions.ts | 1 + src-ts/lib/hooks/use-on-hover-element.hook.ts | 1 + src-ts/lib/hooks/use-window-size.hook.ts | 36 +-- src-ts/lib/info-card/InfoCard.tsx | 2 +- src-ts/lib/loading-spinner/LoadingSpinner.tsx | 2 +- src-ts/lib/modals/base-modal/BaseModal.tsx | 37 ++- src-ts/lib/modals/confirm/ConfirmModal.tsx | 50 ++- src-ts/lib/page-divider/PageDivider.tsx | 2 +- src-ts/lib/payment-form/PaymentForm.tsx | 24 +- src-ts/lib/payment-form/constants/index.tsx | 4 +- src-ts/lib/portal/Portal.tsx | 2 + src-ts/lib/progress-bar/ProgressBar.tsx | 4 +- src-ts/lib/radio-button/RadioButton.tsx | 20 +- src-ts/lib/react-select/ReactSelect.tsx | 154 +++++----- src-ts/lib/restricted-page/RestrictedPage.tsx | 20 +- .../require-auth.provider.tsx | 9 +- src-ts/lib/route-provider/route.provider.tsx | 4 +- src-ts/lib/social-links/facebook/Facebook.tsx | 15 +- .../lib/social-links/instagram/Instagram.tsx | 15 +- .../lib/social-links/linked-in/LinkedIn.tsx | 15 +- .../social-links/social-link/SocialLink.tsx | 1 + src-ts/lib/social-links/twitter/Twitter.tsx | 15 +- src-ts/lib/social-links/youtube/Youtube.tsx | 15 +- .../facebook/FacebookSocialShareBtn.tsx | 21 +- .../linkedin/LinkedinSocialShareBtn.tsx | 21 +- .../twitter/TwitterSocialShareBtn.tsx | 21 +- src-ts/lib/svgs/icon-wrapper/IconWrapper.tsx | 6 +- src-ts/lib/table/Table.tsx | 34 +-- src-ts/lib/table/table-cell/TableCell.tsx | 1 + src-ts/lib/tooltip/Tooltip.tsx | 14 +- .../dev-center-lib/MarkdownDoc/LayoutDoc.tsx | 6 +- .../MarkdownDoc/LayoutDocHeader.tsx | 6 +- .../MarkdownDoc/MarkdownAccordion.tsx | 2 +- .../MarkdownDoc/MarkdownCode.tsx | 12 +- .../MarkdownDoc/MarkdownImages.tsx | 92 +++--- .../MarkdownDoc/MarkdownLink.tsx | 8 +- .../MarkdownDoc/TableOfContents.tsx | 13 +- .../MarkdownDoc/markdownRenderer/renderer.tsx | 62 ++-- .../MarkdownDoc/markdownRenderer/util.ts | 6 +- .../getting-started/GettingStartedGuide.tsx | 24 +- .../landing-page/DevCenterLandingPage.tsx | 17 +- .../ArticleCard/ArticleCard.tsx | 4 +- .../dev-center-articles-section/Articles.ts | 1 + .../DevCenterArticlesSection.tsx | 18 +- .../dev-center-card/DevCenterCard.tsx | 27 +- .../DevCenterGetStarted.tsx | 14 +- .../GetStartedCardsContainer.tsx | 42 ++- .../DevCenterCarousel/DevCenterCarousel.tsx | 24 +- .../DevCenterCarouselItem.tsx | 20 +- .../dev-center-header/DevCenterHeader.tsx | 34 +-- .../carousel-content.config.ts | 10 +- .../dev-center-tag/DevCenterTag.tsx | 12 +- .../game-config/gamification.config.ts | 18 +- .../gamification.default.config.ts | 10 +- .../game-config/gamification.dev.config.ts | 2 +- .../game-config/gamification.prod.config.ts | 4 +- .../BadgeActivatedModal.tsx | 3 +- .../BadgeAssignedModal.tsx | 3 +- .../badge-created-modal/BadgeCreatedModal.tsx | 3 +- .../awarded-members-table.config.tsx | 38 +-- .../MemberActionRenderer.tsx | 34 +-- .../MemberAwaredAtRenderer.tsx | 2 +- .../MemberHandleRenderer.tsx | 20 +- .../pages/badge-detail/BadgeDetailPage.tsx | 5 +- .../BatchAwardTab/BatchAwardTab.tsx | 4 +- .../ManualAwardTab/ManualAwardTab.tsx | 3 +- .../pages/badge-detail/update-badge.store.ts | 3 + .../BadgeActionRenderer.tsx | 36 ++- .../badge-listing-table.config.tsx | 24 +- .../BadgeListingNameRenderer.tsx | 22 +- .../create-badge-form/CreateBadgeForm.tsx | 4 +- .../certificate-view/CertificateView.tsx | 4 +- .../action-button/ActionButton.tsx | 4 +- .../certificate/Certificate.tsx | 20 +- .../CertificateBgPattern.tsx | 15 +- .../certificate/course-card/CourseCard.tsx | 37 ++- .../course-details/CourseDetailsPage.tsx | 24 +- .../course-curriculum/CourseCurriculum.tsx | 4 +- .../curriculum-summary/CurriculumSummary.tsx | 8 +- .../TcAcademyPolicyModal.tsx | 3 +- .../promo-course/PromoCourse.tsx | 47 ++- .../learn/free-code-camp/FreeCodeCamp.tsx | 8 +- .../free-code-camp/fcc-frame/FccFrame.tsx | 1 + .../free-code-camp/title-nav/TitleNav.tsx | 53 ++-- .../collapsible-pane/CollapsiblePane.tsx | 8 +- .../learn-lib/course-badge/CourseBadge.tsx | 3 +- .../course-outline/CourseOutline.tsx | 20 +- .../collapsible-item/CollapsibleItem.tsx | 28 +- .../course-outline/status-icon/StatusIcon.tsx | 2 +- .../course-outline/step-icon/StepIcon.tsx | 4 +- .../learn-lib/course-title/CourseTitle.tsx | 4 +- .../courses-provider/courses.provider.tsx | 1 + .../curriculum-summary/CurriculumSummary.tsx | 10 +- .../learn-lib/functions/learn.factory.ts | 2 + .../my-course-card/completed/Completed.tsx | 6 +- .../my-course-card/in-progress/InProgress.tsx | 18 +- .../user-certifications.provider.tsx | 1 + ...user-completed-certifications.provider.tsx | 6 +- .../learn/learn-lib/wave-hero/WaveHero.tsx | 35 +-- src-ts/tools/learn/learn.routes.tsx | 2 +- src-ts/tools/learn/my-learning/MyLearning.tsx | 2 +- .../learn/my-learning/hero-card/HeroCard.tsx | 65 ++-- .../tab-content-layout/TabContentLayout.tsx | 10 +- .../AvailableCoursesList.tsx | 36 +-- .../welcome/courses-card/CoursesCard.tsx | 4 +- .../cards-slider/CardsSlider.tsx | 30 +- .../progress-block/no-progress/NoProgress.tsx | 22 +- .../work-detail-details/WorkDetailDetails.tsx | 4 +- .../WorkDetailDetailsPane.tsx | 50 +-- .../WorkDetailDetailsSidebar.tsx | 8 +- .../work-detail-header/WorkDetailHeader.tsx | 2 +- .../WorkFeedback/WorkFeedback.tsx | 10 +- .../WorkDetailSolutions.tsx | 2 +- .../WorkSolutionsListItem.tsx | 32 +- .../WorkDetailHighlights.tsx | 52 ++-- .../WorkTransferredStatus.tsx | 46 ++- .../message-functions/message.functions.ts | 10 +- .../work-factory/work.factory.ts | 24 +- .../work-store/work-prices.config.ts | 1 + .../work-store/work-type.config.ts | 2 +- .../work-lib/work-provider/work.provider.tsx | 15 +- .../work-status-item/WorkStatusItem.tsx | 4 +- .../work-login-prompt/WorkLoginPrompt.tsx | 28 +- .../work-not-logged-in/WorkNotLoggedIn.tsx | 2 +- .../bug-hunt/BugHuntIntakeForm.tsx | 9 +- .../bug-hunt/bug-hunt.form.config.tsx | 4 +- .../bug-hunt/bug-hunt.form.pricing-config.tsx | 284 +++++++++--------- .../AboutYourProjectInfoCard.tsx | 62 ++-- .../intake-forms/review/Review.tsx | 22 +- .../save-after-login/SaveAfterLogin.tsx | 2 +- .../work-service-price/WorkServicePrice.tsx | 70 ++--- src-ts/tools/work/work-table/WorkTable.tsx | 2 +- .../work-badge-renderer/WorkBadgeRenderer.tsx | 2 +- .../WorkDeleteButtonRenderer.tsx | 2 +- .../WorkStatusRenderer.tsx | 8 +- .../WorkTableTitleRenderer.tsx | 16 +- .../work/work-type-banner/WorkTypeBanner.tsx | 40 +-- src-ts/tools/work/work.routes.tsx | 2 +- 162 files changed, 1487 insertions(+), 1579 deletions(-) diff --git a/src-ts/header/Header.tsx b/src-ts/header/Header.tsx index 21d045913..bbdc7dd89 100644 --- a/src-ts/header/Header.tsx +++ b/src-ts/header/Header.tsx @@ -5,18 +5,16 @@ import { Logo } from './logo' import { ToolSelectors } from './tool-selectors' import { UtilitySelectors } from './utility-selectors' -const Header: FC<{}> = () => { - return ( -
-
- - - - -
-
-
- ) -} +const Header: FC<{}> = () => ( +
+
+ + + + +
+
+
+) export default Header diff --git a/src-ts/header/tool-selectors/ToolSelectors.tsx b/src-ts/header/tool-selectors/ToolSelectors.tsx index cdc9807cd..1af86631f 100644 --- a/src-ts/header/tool-selectors/ToolSelectors.tsx +++ b/src-ts/header/tool-selectors/ToolSelectors.tsx @@ -7,8 +7,6 @@ interface ToolSelectorsProps { isWide: boolean } -const ToolSelectors: FC = (props: ToolSelectorsProps) => { - return props.isWide ? : -} +const ToolSelectors: FC = (props: ToolSelectorsProps) => props.isWide ? : export default ToolSelectors diff --git a/src-ts/header/tool-selectors/tool-selectors-wide/tool-selector-wide/ToolSelectorWide.tsx b/src-ts/header/tool-selectors/tool-selectors-wide/tool-selector-wide/ToolSelectorWide.tsx index e30a3c5ba..f87c68723 100644 --- a/src-ts/header/tool-selectors/tool-selectors-wide/tool-selector-wide/ToolSelectorWide.tsx +++ b/src-ts/header/tool-selectors/tool-selectors-wide/tool-selector-wide/ToolSelectorWide.tsx @@ -46,7 +46,7 @@ const ToolSelectorWide: FC = (props: ToolSelectorWideProp > {toolRoute.title} -
+
) } diff --git a/src-ts/header/utility-selectors/UtilitySelectors.tsx b/src-ts/header/utility-selectors/UtilitySelectors.tsx index 8d5b3136a..a909a7769 100644 --- a/src-ts/header/utility-selectors/UtilitySelectors.tsx +++ b/src-ts/header/utility-selectors/UtilitySelectors.tsx @@ -3,13 +3,11 @@ import { FC } from 'react' import ProfileSelector from './UtilitySelector/ProfileSelector/ProfileSelector' import styles from './UtilitySelectors.module.scss' -const UtilitySelectors: FC<{}> = () => { - return ( -
- {/* TODO: make this configurable */} - -
- ) -} +const UtilitySelectors: FC<{}> = () => ( +
+ {/* TODO: make this configurable */} + +
+) export default UtilitySelectors diff --git a/src-ts/index.ts b/src-ts/index.ts index a8d7d77fe..c402cb788 100644 --- a/src-ts/index.ts +++ b/src-ts/index.ts @@ -4,22 +4,22 @@ export { default as AppNextGen } from './App' export { EnvironmentConfig } from './config' export { - Analytics, - Breadcrumb, - ContactSupportModal, - logInitialize, - OrderContractModal, - PageFooter, - PrivacyPolicyModal, - profileContext, - ProfileProvider, - RouteProvider, - TabsNavbar, - TermsModal, - xhrGetAsync, - xhrGetBlobAsync, - xhrPatchAsync, - xhrPostAsync, + Analytics, + Breadcrumb, + ContactSupportModal, + logInitialize, + OrderContractModal, + PageFooter, + PrivacyPolicyModal, + profileContext, + ProfileProvider, + RouteProvider, + TabsNavbar, + TermsModal, + xhrGetAsync, + xhrGetBlobAsync, + xhrPatchAsync, + xhrPostAsync, } from './lib' export * from './tools' export * from './utils' diff --git a/src-ts/lib/analytics/Analytics.tsx b/src-ts/lib/analytics/Analytics.tsx index 91b842ab9..ace4d5256 100644 --- a/src-ts/lib/analytics/Analytics.tsx +++ b/src-ts/lib/analytics/Analytics.tsx @@ -3,14 +3,11 @@ import { FC } from 'react' import { GoogleTagManager } from './google-tag-manater' import { SegmentAnalytics } from './segment-analytics' -const Analytics: FC<{}> = () => { - - return ( - <> - - - - ) -} +const Analytics: FC<{}> = () => ( + <> + + + +) export default Analytics diff --git a/src-ts/lib/breadcrumb/breadcrumb-item/BreadcrumbItem.tsx b/src-ts/lib/breadcrumb/breadcrumb-item/BreadcrumbItem.tsx index e9ab23f50..41401ddb3 100644 --- a/src-ts/lib/breadcrumb/breadcrumb-item/BreadcrumbItem.tsx +++ b/src-ts/lib/breadcrumb/breadcrumb-item/BreadcrumbItem.tsx @@ -1,7 +1,7 @@ import { FC } from 'react' import { Link } from 'react-router-dom' -import styles from './../Breadcrumb.module.scss' +import styles from "../Breadcrumb.module.scss" import { BreadcrumbItemModel } from './breadcrumb-item.model' interface BreadcrumbItemProps { @@ -9,14 +9,12 @@ interface BreadcrumbItemProps { item: BreadcrumbItemModel } -const BreadcrumbItem: FC = (props: BreadcrumbItemProps) => { - return ( -
  • props.item.onClick?.(props.item)}> - - {props.item.name} - -
  • - ) -} +const BreadcrumbItem: FC = (props: BreadcrumbItemProps) => ( +
  • props.item.onClick?.(props.item)}> + + {props.item.name} + +
  • +) export default BreadcrumbItem diff --git a/src-ts/lib/contact-support-form/ContactSupportForm.tsx b/src-ts/lib/contact-support-form/ContactSupportForm.tsx index 7315230af..68a8cac0f 100644 --- a/src-ts/lib/contact-support-form/ContactSupportForm.tsx +++ b/src-ts/lib/contact-support-form/ContactSupportForm.tsx @@ -23,9 +23,9 @@ const ContactSupportForm: FC = (props: ContactSupportFo const [saveOnSuccess, setSaveOnSuccess]: [boolean, Dispatch>] = useState(false) useEffect(() => { - if (!loading && saveOnSuccess) { - props.onSave() - } + if (!loading && saveOnSuccess) { + props.onSave() + } }, [loading, saveOnSuccess]) function generateRequest(inputs: ReadonlyArray): ContactSupportRequest { @@ -47,7 +47,7 @@ const ContactSupportForm: FC = (props: ContactSupportFo setLoading(true) return contactSupportSubmitRequestAsync(request) .then(() => { - setSaveOnSuccess(true) + setSaveOnSuccess(true) }).finally(() => setLoading(false)) } diff --git a/src-ts/lib/content-layout/ContentLayout.tsx b/src-ts/lib/content-layout/ContentLayout.tsx index a6bbbb6f0..0a56dcd51 100644 --- a/src-ts/lib/content-layout/ContentLayout.tsx +++ b/src-ts/lib/content-layout/ContentLayout.tsx @@ -16,42 +16,40 @@ export interface ContentLayoutProps { titleClass?: string } -const ContentLayout: FC = (props: ContentLayoutProps) => { - return ( -
    +const ContentLayout: FC = (props: ContentLayoutProps) => ( +
    -
    +
    -
    +
    - {!!props.title && ( -
    + {!!props.title && ( +
    -

    - {props.title} -

    +

    + {props.title} +

    - {!!props.buttonConfig && ( -
    -
    - )} + {!!props.buttonConfig && ( +
    +
    + )} -
    - )} +
    + )} - {props.children} - -
    + {props.children}
    - ) -} + +
    +) export default ContentLayout diff --git a/src-ts/lib/form/Form.tsx b/src-ts/lib/form/Form.tsx index 4f0817a14..afbc7b36e 100644 --- a/src-ts/lib/form/Form.tsx +++ b/src-ts/lib/form/Form.tsx @@ -86,11 +86,9 @@ const Form: (props: FormProps { - return () => { - if (props.resetFormOnUnmount) { - onReset() - } + useEffect(() => () => { + if (props.resetFormOnUnmount) { + onReset() } }, []) @@ -148,34 +146,32 @@ const Form: (props: FormProps FormButton = (button) => { - // if this is a reset button, set its onclick to reset - if (!!button.isReset) { - button = { - ...button, - onClick: onReset, - } - } - - return button - } + // if this is a reset button, set its onclick to reset + if (!!button.isReset) { + button = { + ...button, + onClick: onReset, + } + } - const createButtonGroup: (groups: ReadonlyArray, isPrimaryGroup: boolean) => Array = (groups, isPrimaryGroup) => { - return groups.map((button, index) => { - button = setOnClickOnReset(button) - - const disabled: boolean = (button.isSubmit && isFormInvalid) || !!props.shouldDisableButton?.(isPrimaryGroup, index) - - return ( -