Skip to content

Commit c8219df

Browse files
committed
PROD-2708 #comment Improve readability of the bug hunt package
1 parent b011ce9 commit c8219df

File tree

2 files changed

+47
-14
lines changed

2 files changed

+47
-14
lines changed

src-ts/lib/form/form-groups/form-card-set/FormCardSet.module.scss

Lines changed: 44 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717
flex: 1 1 0;
1818
margin-right: $space-xl;
1919
border-radius: $space-xs;
20-
padding: $space-lg 0;
20+
padding: $space-xxl 0px 0px;
2121
background-color: $black-5;
2222
position: relative;
23+
height: calc($space-xl * 30);
2324

2425
.popular-card {
2526
display: flex;
@@ -61,19 +62,25 @@
6162
align-items: center;
6263

6364
h3 {
64-
margin: $space-lg;
65+
margin: $space-xxl $space-lg;
6566
font-weight: 500;
66-
font-size: $space-mx;
67+
font-size: calc($space-mx + $space-xs);
6768
line-height: $space-mx;
68-
margin-top: $space-xxl;
69+
}
70+
71+
.body-medium-bold {
72+
font-weight: 700;
73+
font-size: $space-xxl;
74+
font-family: "Roboto";
75+
padding: 0;
76+
line-height: calc($space-xxl - 2px);
6977
}
7078

7179
&.feature {
7280
visibility: hidden;
7381

7482
h3 {
75-
margin: $space-lg;
76-
margin-top: $space-xxl;
83+
margin: $space-xxl $space-lg;
7784
font-size: $space-xxxxl;
7885
}
7986
}
@@ -82,9 +89,15 @@
8289
h3 {
8390
font-size: $space-xxxxl;
8491
line-height: $space-xxxxl;
85-
margin-top: $space-md;
92+
margin-top: $space-sm;
8693
margin-bottom: $space-xxl;
8794
}
95+
96+
.body-medium-bold {
97+
font-size: $space-xl;
98+
line-height: $space-xxxxl;
99+
font-style: normal;
100+
}
88101
}
89102
}
90103

@@ -97,24 +110,36 @@
97110
}
98111

99112
.card-section {
100-
margin: $space-lg 0;
113+
margin: $space-mx 0;
101114

102115
.row {
103116
height: auto;
117+
118+
&:last-child {
119+
.row-divider {
120+
&:last-child {
121+
display: block;
122+
}
123+
}
124+
}
104125
}
105126

106127
.row-divider {
107128
height: $border-xs;
108129
border-bottom: $border solid $black-10;
109130
width: auto;
110131
margin: 0;
132+
133+
&:last-child {
134+
display: none;
135+
}
111136
}
112137

113138
.card-row {
114139
display: flex;
115140
padding: $space-md;
116141
align-items: center;
117-
min-height: calc($space-lg + $space-mx);
142+
min-height: calc($space-lg + $space-mx - 2px);
118143
position: relative;
119144

120145
.card-row-col {
@@ -156,6 +181,7 @@
156181
}
157182
}
158183
&.mobile {
184+
margin-bottom: 0;
159185
.feature-name {
160186
width: 100%;
161187
}
@@ -164,13 +190,14 @@
164190
}
165191
}
166192
&.feature {
167-
margin: calc($space-lg - 0.2px) 0;
193+
margin-top: $space-mx;
168194
}
169195
}
170196

171197
&.feature {
172198
background-color: $tc-white;
173199
margin-right: 0;
200+
flex-grow: 0.9;
174201

175202
.card-row-col:nth-child(2) {
176203
display: none;
@@ -188,9 +215,14 @@
188215
}
189216

190217
svg.card-row-icon {
191-
height: 14px;
192-
width: 14px;
218+
height: 24px;
219+
width: 24px;
193220
display: inline;
194221
margin-right: 6px;
222+
223+
@include ltemd {
224+
height: 16px;
225+
width: 16px;
226+
}
195227
}
196228
}

src-ts/lib/form/form-groups/form-card-set/FormCardSet.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const FormCardSet: React.FC<FormCardSetProps> = ({ name, cards, onChange, value
4949
<div key={`card-${index}`}className={cn(styles['card'], selected && styles['selected'], isMobile && card.mostPopular && styles['mobile-popular'], { [styles.feature]: index === 0, [styles.mobile]: isMobile })}>
5050
{ card.mostPopular && <div className={styles['popular-card']}>MOST POPULAR</div>}
5151
<div className={cn(styles['card-header'], isMobile && styles['mobile'], { [styles.feature]: index === 0 })}>
52-
<div className='body-medium-bold'>{card.title}</div>
52+
<div className={styles['body-medium-bold']}>{card.title}</div>
5353
<h3>{formattedPrice}</h3>
5454
{getButton(card, selected)}
5555
</div>
@@ -77,12 +77,13 @@ const FormCardSet: React.FC<FormCardSetProps> = ({ name, cards, onChange, value
7777
{(
7878
<span className={cn(styles['card-row-col'], styles['center'])}>
7979
{ row.valueIcon ?
80-
<IconOutline.CheckIcon width={18} height={16} /> :
80+
<IconOutline.CheckIcon width={28} height={20} /> :
8181
<span className='body-main'>{row.text}</span>
8282
}
8383
</span>
8484
)}
8585
</div>
86+
<div className={styles['row-divider']}></div>
8687
</div>
8788
))}
8889
</div>

0 commit comments

Comments
 (0)