Skip to content

Commit 863d5b5

Browse files
authored
Merge pull request #538 from topcoder-platform/qa-fixes
Multiple QA fixes -> dev
2 parents 8dab0d0 + b6ba817 commit 863d5b5

File tree

7 files changed

+24
-17
lines changed

7 files changed

+24
-17
lines changed

src-ts/lib/styles/_layout.scss

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,16 @@
22
@import 'mixins';
33

44
html {
5-
--header-height: 80px;
6-
--footer-height: 51px;
5+
--header-height: 60px;
6+
--footer-height: 96px;
77
--breadcrumb-height: 64px;
88

9-
@include ltemd {
10-
--header-height: 64px;
11-
--breadcrumb-height: 48px;
9+
@media (max-width: 767px) {
10+
--header-height: 48px;
1211
}
1312

14-
@include ltesm {
15-
--header-height: 48px;
16-
--footer-height: 101px;
13+
@include ltemd {
14+
--breadcrumb-height: 48px;
1715
}
1816
}
1917

src-ts/tools/learn/certification-details/certification-curriculum/curriculum-cards/course-card/CourseCard.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const CourseCard: FC<CourseCardProps> = (props: CourseCardProps) => {
8686
}
8787

8888
const completionTimeRange: TCACertificationCompletionTimeRange = useHoursEstimateToRange(
89-
props.certification.completionHours,
89+
props.certification.course.estimatedCompletionTimeValue,
9090
)
9191

9292
return (
@@ -108,7 +108,10 @@ const CourseCard: FC<CourseCardProps> = (props: CourseCardProps) => {
108108
<span className={styles.icon}>
109109
<IconSolid.DocumentTextIcon />
110110
</span>
111-
<span className='quote-small'>4 modules</span>
111+
<span className='quote-small'>
112+
{props.certification.course.modules.length}
113+
{' modules'}
114+
</span>
112115
</li>
113116
<li className={styles.stat}>
114117
<span className={styles.icon}>

src-ts/tools/learn/certification-details/enrollment-page/enrollment-sidebar/EnrollmentSidebar.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@ const EnrollmentSidebar: FC<EnrollmentSidebarProps> = (props: EnrollmentSidebarP
2424
Enroll until April 30 with no cost.
2525
</div>
2626
</div>
27-
<Button buttonStyle='primary' onClick={props.onEnroll} label='Enroll Now' size='lg' />
27+
<Button
28+
buttonStyle='primary'
29+
onClick={props.onEnroll}
30+
label='Complete Enrollment'
31+
size='lg'
32+
/>
2833
{/* TODO: this form will probably be re-used when we add actuall payments, leaving this here for now */}
2934
{/* <EnrollmentForm profile={props.profile} onSubmit={props.onEnroll}>
3035
</EnrollmentForm> */}

src-ts/tools/learn/course-details/CourseDetailsPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ const CourseDetailsPage: FC<{}> = () => {
9393
{' '}
9494
{course.title}
9595
,
96-
we&appos;d recommend you enroll in another course to continue your learning.
96+
we&apos;d recommend you enroll in another course to continue your learning.
9797
You can view our other courses from the Topcoder Academy course page.
9898
</p>
9999
</div>

src-ts/tools/learn/learn-lib/tca-certificate-preview/tca-certificate/TCACertificate.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
position: absolute;
1212
top: 0;
1313
left: 0;
14-
right: 0;
15-
bottom: 0;
14+
width: 100%;
15+
height: 100%;
1616
z-index: -1;
1717
}
1818

src-ts/tools/learn/learn-lib/tca-certificate-preview/tca-certificate/certificate-background/certificate-bg.svg

Lines changed: 2 additions & 2 deletions
Loading

src-ts/tools/learn/welcome/courses-card/CoursesCard.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import classNames from 'classnames'
33

44
import { Button, FccLogoBlackSvg, IconSolid, ProgressBar } from '../../../../lib'
55
import {
6+
clearFCCCertificationTitle,
67
CompletionTimeRange,
78
CourseBadge,
89
LearnCertification,
@@ -67,7 +68,7 @@ const CoursesCard: FC<CoursesCardProps> = (props: CoursesCardProps) => {
6768
<div className={styles.cardHeader}>
6869
<CourseBadge type={props.certification.certificationCategory.track ?? 'DEV'} />
6970
<div className={styles.cardHeaderTitleWrap}>
70-
<p className='body-medium-medium'>{props.certification.title}</p>
71+
<p className='body-medium-medium'>{clearFCCCertificationTitle(props.certification.title)}</p>
7172
<div className={styles.subTitleWrap}>
7273
<LearnLevelIcon level={props.certification.learnerLevel} />
7374
<span className={classNames('body-small', styles.infoText)}>

0 commit comments

Comments
 (0)