TCA-499 more clean up

Author: brooketopcoder

src-ts/.eslintrc.js

@@ -98,6 +98,8 @@ module.exports = {
             'error',
             'prefer-single'
         ],
+        'jsx-a11y/click-events-have-key-events': 'warn',
+        'jsx-a11y/no-static-element-interactions': 'warn',
         'jsx-a11y/tabindex-no-positive': [
             'warn'
         ],

src-ts/config/environments/environment.default.config.ts

@@ -1,3 +1,4 @@
+/* eslint-disable max-len */
 import { EnvironmentConfigModel } from './environment-config.model'
 
 const COMMUNITY_WEBSITE: string = 'https://www.topcoder-dev.com'

src-ts/config/environments/environment.dev.config.ts

@@ -1,3 +1,4 @@
+/* eslint-disable max-len */
 import { EnvironmentConfigModel } from './environment-config.model'
 import { EnvironmentConfigDefault } from './environment.default.config'
 

src-ts/config/environments/environment.prod.config.ts

@@ -1,3 +1,4 @@
+/* eslint-disable max-len */
 import { EnvironmentConfigModel } from './environment-config.model'
 import { EnvironmentConfigDefault } from './environment.default.config'
 

src-ts/lib/generic-data-object.type.ts

@@ -0,0 +1 @@
+export type GenericDataObject = { [key: string]: string | GenericDataObject }

src-ts/lib/global-config.model.ts

@@ -11,9 +11,6 @@ export interface GlobalConfig {
     }
     DISABLED_TOOLS?: Array<string>
     ENV: string
-    GAMIFICATION: {
-        ORG_ID: string
-    },
     LOGGING: {
         PUBLIC_TOKEN: string
         SERVICE: string

src-ts/lib/index.ts

@@ -29,6 +29,7 @@ export {
     xhrPostAsync,
     xhrPutAsync,
 } from './functions'
+export * from './generic-data-object.type'
 export * from './global-config.model'
 export * from './hooks'
 export * from './info-card'

src-ts/lib/profile-provider/profile.provider.tsx

@@ -11,7 +11,8 @@ import profileContext, { defaultProfileContextData } from './profile.context'
 
 export const ProfileProvider: FC<{ children: ReactNode }> = ({ children }: { children: ReactNode }) => {
 
-    const [profileContextData, setProfileContextData]: [ProfileContextData, Dispatch<SetStateAction<ProfileContextData>>]
+    const [profileContextData, setProfileContextData]:
+        [ProfileContextData, Dispatch<SetStateAction<ProfileContextData>>]
         = useState<ProfileContextData>(defaultProfileContextData)
 
     function changePassword(userId: number, request: ChangePasswordRequest): Promise<void> {

src-ts/tools/learn/learn-lib/data-providers/user-certifications-provider/user-certifications-functions/user-certification-progress.store.ts

@@ -1,3 +1,4 @@
+import { GenericDataObject } from '../../../../../../lib'
 import { LearnConfig } from '../../../../learn-config'
 import { getUserCertificateUrl } from '../../../../learn.routes'
 import { learnUrlGet, learnXhrPostAsync, learnXhrPutAsync } from '../../../functions'
@@ -7,8 +8,6 @@ import { UserCertificationUpdateProgressActions } from './user-certification-upd
 
 const certProgressPath: string = 'certification-progresses'
 
-type GenericDataObject = { [key: string]: string | GenericDataObject }
-
 export function completeCourse(
     certificationProgressId: string,
     certification: string,
@@ -37,7 +36,7 @@ export function startAsync(
     userId: number,
     certificationId: string,
     courseId: string,
-    data: any,
+    data: GenericDataObject,
 ): Promise<LearnUserCertificationProgress> {
 
     const url: string = learnUrlGet(certProgressPath, `${userId}`, certificationId, courseId)

src-ts/tools/work/work-lib/work-provider/work-functions/work.functions.ts

@@ -1,6 +1,6 @@
 import { PaymentMethodResult, Stripe, StripeCardNumberElement } from '@stripe/stripe-js'
 
-import { Page, UserProfile } from '../../../../../lib'
+import { GenericDataObject, Page, UserProfile } from '../../../../../lib'
 
 import { WorkByStatus } from './work-by-status.model'
 import {
@@ -58,17 +58,14 @@ export async function createCustomerPaymentAsync(
 
     // if we don't have the bare min, don't do anything
     if (!stripe || !cardNumber || !challenge) {
-        return
+        return undefined
     }
 
     // initialize the payment method
     const payload: PaymentMethodResult = await stripe.createPaymentMethod({
         card: cardNumber,
         type: 'card',
     })
-    if (!payload) {
-        return
-    }
 
     // make the request to make the payment
     const paymentRequest: CustomerPaymentRequest = workFactoryBuildCustomerPaymentRequest(
@@ -122,8 +119,11 @@ export async function getByWorkIdAsync(workId: string): Promise<Challenge> {
 export function getGroupedByStatus(work: ReadonlyArray<Work>): { [status: string]: WorkByStatus } {
     const output: { [status: string]: WorkByStatus } = {}
     Object.entries(WorkStatusFilter)
-        .forEach(([key, value]) => {
-            const results: ReadonlyArray<Work> = workStoreGetFilteredByStatus(work, WorkStatusFilter[key as keyof typeof WorkStatusFilter])
+        .forEach(([key]) => {
+            const results: ReadonlyArray<Work> = workStoreGetFilteredByStatus(
+                work,
+                WorkStatusFilter[key as keyof typeof WorkStatusFilter],
+            )
             output[key] = {
                 count: results.length,
                 messageCount: results.reduce((partialSum, a) => partialSum + (a.messageCount ?? 0), 0),
@@ -147,15 +147,15 @@ export function getStatusFilter(filterKey?: string): WorkStatusFilter | undefine
 
     // get the filter key from the passed in key
     const workStatusFilter: keyof typeof WorkStatusFilter | undefined = Object.entries(WorkStatusFilter)
-        .find(([key, value]) => key === filterKey)
+        .find(([key]) => key === filterKey)
         ?.[0] as keyof typeof WorkStatusFilter
 
     // if the passed in key doesn't match any filter, return undefined;
     // otherwise, return the filter defined by the key
     return !workStatusFilter ? undefined : WorkStatusFilter[workStatusFilter]
 }
 
-export async function updateAsync(type: WorkType, challenge: Challenge, intakeForm: any): Promise<void> {
+export async function updateAsync(type: WorkType, challenge: Challenge, intakeForm: GenericDataObject): Promise<void> {
     const workConfig: WorkTypeConfig = WorkTypeConfigs[type]
     const body: UpdateWorkRequest = workFactoryBuildUpdateRequest(workConfig, challenge, intakeForm)
     return workStoreUpdateAsync(body)

src-ts/tools/work/work-self-service/intake-forms/review/Review.tsx

@@ -275,9 +275,10 @@ const Review: FC = () => {
     )
 }
 
-let stripePromise: Promise<Stripe | null | undefined>
+let stripePromise: Promise<Stripe | null | undefined> | undefined
 
 const output: () => JSX.Element = () => {
+
     if (!stripePromise) {
         stripePromise = loadStripe(EnvironmentConfig.STRIPE.API_KEY, {
             apiVersion: EnvironmentConfig.STRIPE.API_VERSION,

src-ts/tools/work/work-self-service/intake-forms/save-after-login/SaveAfterLogin.tsx

@@ -1,8 +1,8 @@
 import { FC, useEffect } from 'react'
 import { NavigateFunction, useNavigate } from 'react-router-dom'
 
-import { LoadingSpinner } from '../../../../../lib'
-import { workCreateAsync, WorkIntakeFormRoutes, WorkType, workUpdateAsync } from '../../../work-lib'
+import { GenericDataObject, LoadingSpinner } from '../../../../../lib'
+import { Challenge, workCreateAsync, WorkIntakeFormRoutes, WorkType, workUpdateAsync } from '../../../work-lib'
 import { selfServiceStartRoute } from '../../../work.routes'
 
 /**
@@ -19,12 +19,12 @@ const SaveAfterLogin: FC = () => {
     useEffect(() => {
         const createAndUpdateAsync: () => Promise<void> = async () => {
             try {
-                if (localStorage && localStorage.getItem('challengeInProgress') && localStorage.getItem('challengeInProgressType')) {
+                if (localStorage.getItem('challengeInProgress') && localStorage.getItem('challengeInProgressType')) {
                     const workType: WorkType = localStorage.getItem('challengeInProgressType') as WorkType
-                    const formData: any = JSON.parse(String(localStorage.getItem('challengeInProgress')))
+                    const formData: GenericDataObject = JSON.parse(String(localStorage.getItem('challengeInProgress')))
                     formData.currentStep = 'review'
 
-                    const challenge: any = await workCreateAsync(workType)
+                    const challenge: Challenge = await workCreateAsync(workType)
 
                     await workUpdateAsync(workType, challenge, formData)