Skip to content

Commit 4e51e01

Browse files
committed
PROD-2534 - fix lint issues
1 parent 8a0df39 commit 4e51e01

File tree

5 files changed

+24
-15
lines changed

5 files changed

+24
-15
lines changed

src-ts/tools/learn/course-details/CourseDetailsPage.tsx

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,21 @@ const CourseDetailsPage: FC<{}> = () => {
8585
)
8686
}
8787

88+
function getFooter(): ReactNode {
89+
if (!resourceProvider) {
90+
return
91+
}
92+
93+
return (
94+
<div className={styles['credits-link']}>
95+
<a href={`//${resourceProvider.url}`} target='_blank' referrerPolicy='no-referrer' rel='noreferrer'>
96+
This course was created by the {resourceProvider.url} community.
97+
<IconOutline.ExternalLinkIcon />
98+
</a>
99+
</div>
100+
)
101+
}
102+
88103
return (
89104
<ContentLayout>
90105
{!ready && (
@@ -121,14 +136,7 @@ const CourseDetailsPage: FC<{}> = () => {
121136
/>
122137
</div>
123138
</div>
124-
{resourceProvider && (
125-
<div className={styles['credits-link']}>
126-
<a href={`//${resourceProvider.url}`} target='_blank' referrerPolicy='no-referrer' rel='noreferrer'>
127-
This course was created by the {resourceProvider.url} community.
128-
<IconOutline.ExternalLinkIcon />
129-
</a>
130-
</div>
131-
)}
139+
{getFooter()}
132140
</>
133141
)}
134142
</ContentLayout>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { ResourceProvider } from './resource-provider-functions'
22

33
export interface ResourceProviderData {
4-
provider?: ResourceProvider
54
loading: boolean
5+
provider?: ResourceProvider
66
ready: boolean
77
}
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export interface ResourceProvider {
22
attributionStatement: string
33
id: string
4-
url: string
54
name: string
5+
url: string
66
}

src-ts/tools/learn/learn-lib/resource-provider-provider/resource-provider-functions/resource-provider.store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { xhrGetAsync } from '../../../../../lib/functions'
22
import { getPath } from '../../learn-url.config'
3-
import { ResourceProvider } from './resource-provider.model'
43

4+
import { ResourceProvider } from './resource-provider.model'
55

66
export function getResourceProvidersAsync(): Promise<Array<ResourceProvider>|undefined> {
77
return xhrGetAsync<Array<ResourceProvider>>(getPath(

src-ts/tools/learn/learn-lib/resource-provider-provider/resource-provider.provider.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { Dispatch, SetStateAction, useEffect, useState } from 'react'
2+
23
import { ResourceProviderData } from './resource-provider-data.model'
34
import { getResourceProvidersAsync } from './resource-provider-functions/resource-provider.store'
45

@@ -7,13 +8,13 @@ export function useResourceProvider(providerName?: string): ResourceProviderData
78
loading: false,
89
ready: false,
910
})
10-
11+
1112
useEffect(() => {
1213
if (!providerName) {
1314
setState((prevState) => ({
1415
...prevState,
15-
provider: undefined,
1616
loading: false,
17+
provider: undefined,
1718
ready: false,
1819
}))
1920
return
@@ -27,12 +28,12 @@ export function useResourceProvider(providerName?: string): ResourceProviderData
2728
getResourceProvidersAsync().then((providers) => {
2829
setState((prevState) => ({
2930
...prevState,
30-
provider: providers?.find(p => p.name === providerName),
3131
loading: false,
32+
provider: providers?.find(p => p.name === providerName),
3233
ready: true,
3334
}))
3435
})
3536
}, [providerName])
3637

3738
return state
38-
}
39+
}

0 commit comments

Comments
 (0)