fix: review comments

Author: hentrymartin

src/apps/copilots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx

@@ -19,17 +19,21 @@ const ApplyOpportunityModal: FC<ApplyOpportunityModalProps> = props => {
     const [success, setSuccess] = useState(false)
 
     const onApply = useCallback(async () => {
-        await applyCopilotOpportunity(props.copilotOpportunityId, {
-            notes,
-        })
+        try {
+            await applyCopilotOpportunity(props.copilotOpportunityId, {
+                notes,
+            })
 
-        props.onApplied()
-        setSuccess(true)
+            props.onApplied()
+            setSuccess(true)
+        } catch (e) {
+            setSuccess(true)
+        }
     }, [props.copilotOpportunityId, notes])
 
-    const onChange: (e: React.ChangeEvent<HTMLTextAreaElement>) => void = e => {
+    const onChange: (e: React.ChangeEvent<HTMLTextAreaElement>) => void = useCallback(e => {
         setNotes(e.target.value)
-    }
+    }, [setNotes])
 
     return (
         <BaseModal

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

@@ -1,5 +1,12 @@
 /* eslint-disable react/jsx-no-bind */
-import { FC, useContext, useEffect, useMemo, useState } from 'react'
+import {
+    FC,
+    useCallback,
+    useContext,
+    useEffect,
+    useMemo,
+    useState,
+} from 'react'
 import { useNavigate, useParams } from 'react-router-dom'
 import { mutate } from 'swr'
 import moment from 'moment'
@@ -53,6 +60,14 @@ const CopilotOpportunityDetails: FC<{}> = () => {
         return () => clearTimeout(timer) // Cleanup on unmount
     }, [opportunity])
 
+    const onApplied: () => void = useCallback(() => {
+        mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`)
+    }, [])
+
+    const onCloseApplyModal: () => void = useCallback(() => {
+        setShowApplyOpportunityModal(false)
+    }, [setShowApplyOpportunityModal])
+
     if (!opportunity && showNotFound) {
         return (
             <ContentLayout title='Copilot Opportunity Details'>
@@ -67,14 +82,6 @@ const CopilotOpportunityDetails: FC<{}> = () => {
         onClick: () => setShowApplyOpportunityModal(true),
     }
 
-    const onApplied: () => void = () => {
-        mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`)
-    }
-
-    const onCloseApplyModal: () => void = () => {
-        setShowApplyOpportunityModal(false)
-    }
-
     return (
         <ContentLayout
             title='Copilot Opportunity'

src/apps/copilots/src/services/copilot-opportunities.ts

@@ -120,8 +120,5 @@ export const useCopilotApplications = (opportunityId?: string): CopilotApplicati
         .then(data => data)
         .catch(() => [])
 
-    return useSWR(url, fetcher, {
-        refreshInterval: 0,
-        revalidateOnFocus: false,
-    })
+    return useSWR(url, fetcher)
 }