Skip to content

Commit 4824a52

Browse files
committed
code review updates
1 parent 37b4ea6 commit 4824a52

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src-ts/tools/learn/welcome/WelcomePage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const WelcomePage: FC = () => {
2828

2929
const coursesReady: boolean = allCertsData.ready && userCertsData.ready
3030

31+
// TODO: this hook is mocked - remove mock when API is available...
3132
const allTCACertifications: TCACertificationsProviderData = useGetAllTCACertificationsMOCK()
3233

3334
return (

src-ts/tools/learn/welcome/tc-certifications/TCCertifications.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { FC, ReactNode, useCallback } from 'react'
22

3-
import { TCACertification } from '../../learn-lib/data-providers/tca-certifications-provider'
3+
import { TCACertification } from '../../learn-lib'
44

55
import { TCCertCard } from './cert-card'
66

src-ts/tools/learn/welcome/tc-certifications/cert-card/TCCertCard.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { FC, memo, ReactNode } from 'react'
22
import classNames from 'classnames'
33

44
import { FccLogoBlackSvg, IconLevel1, IconLevel2, IconLevel3, IconSolid } from '../../../../../lib'
5-
import { TCACertification } from '../../../learn-lib/data-providers/tca-certifications-provider'
5+
import { TCACertification } from '../../../learn-lib'
66
import { SkillLabel } from '../../skill'
77
import { ReactComponent as TCACertBadgeDEV1 } from '../assets/web-dev-cert-badge-1.svg'
88

@@ -26,6 +26,8 @@ const TCCertCard: FC<TCCertCardProps> = (props: TCCertCardProps) => {
2626
return (
2727
<div className={styles.wrap}>
2828
<div className={styles.cardHeader}>
29+
{/* TODO: move this to import from learn-lib/svgs
30+
when implementing render logic based on learneLevel field... */}
2931
<TCACertBadgeDEV1 />
3032
<div className={styles.cardTitleWrap}>
3133
<p className='body-large-medium'>{props.certification.title}</p>

0 commit comments

Comments
 (0)