Skip to content

Commit 26face4

Browse files
committed
Fix for GitHub bot suggestions
1 parent 1c6ab4c commit 26face4

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/apps/admin/src/lib/components/RolesFilter/RolesFilter.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,9 @@ export const RolesFilter: FC<Props> = props => {
107107
return (
108108
<form
109109
className={classNames(styles.container, props.className)}
110+
// Add this to prevent the unexpected action
111+
// We only need to trigger submit when the submit button is clicked,
112+
// and this is already handled by the onClick event of the submit button
110113
onSubmit={_.noop}
111114
>
112115
<div className={styles.fields}>

src/apps/admin/src/lib/utils/validation.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,9 @@ export const formRolesFilterSchema: Yup.ObjectSchema<FormRolesFilter>
256256
roleName: Yup.object()
257257
.shape({
258258
label: Yup.string()
259-
.required('label id is required.'),
259+
.required('Label is required.'),
260260
value: Yup.string()
261-
.required('value is required.'),
261+
.required('Value is required.'),
262262
})
263263
.required('Role is required.'),
264264
})

0 commit comments

Comments
 (0)