Skip to content

Commit 0a7aa84

Browse files
authored
Merge pull request #529 from topcoder-platform/TCA-984_enrolled-modal-text
TCA-984 - update enrollment flow -> dev
2 parents 8f87ed6 + 35bae49 commit 0a7aa84

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

src-ts/tools/learn/certification-details/enrolled-modal/EnrolledModal.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { TCACertification } from '../../learn-lib'
66
import styles from './EnrolledModal.module.scss'
77

88
interface EnrolledModalProps {
9-
certification: TCACertification
109
isOpen: boolean
1110
onClose: () => void
1211
}
@@ -29,10 +28,7 @@ const EnrolledModal: FC<EnrolledModalProps> = (props: EnrolledModalProps) => {
2928
>
3029
<>
3130
<h2 className='details'>
32-
You have Successfully Enrolled in the
33-
{' '}
34-
{props.certification.title}
35-
!
31+
You have successfully enrolled!
3632
</h2>
3733
<Button buttonStyle='outline' label='Close' onClick={props.onClose} />
3834
</>

src-ts/tools/learn/certification-details/enrollment-page/EnrollmentPage.tsx

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
SetStateAction,
77
useCallback,
88
useContext,
9+
useEffect,
910
useLayoutEffect,
1011
useRef,
1112
useState,
@@ -27,7 +28,6 @@ import {
2728
useGetTCACertification,
2829
useGetTCACertificationProgress,
2930
useTCACertificationCheckCompleted,
30-
useTcaCertificationModal,
3131
} from '../../learn-lib'
3232
import { perks } from '../certification-details-modal/certif-details-content/data'
3333
import { PerksSection } from '../perks-section'
@@ -60,6 +60,7 @@ const EnrollmentPage: FC<{}> = () => {
6060
const {
6161
progress,
6262
ready: progressReady,
63+
refetch: refetchProgress,
6364
setCertificateProgress,
6465
}: TCACertificationProgressProviderData = useGetTCACertificationProgress(
6566
profile?.userId as unknown as string,
@@ -72,17 +73,14 @@ const EnrollmentPage: FC<{}> = () => {
7273
const firstResourceProgress: TCACertificationProgress['resourceProgresses'][0] | undefined
7374
= progress?.resourceProgresses?.[0]
7475

75-
const { certification: tcaCertificationName }: TCACertificationCheckCompleted = useTCACertificationCheckCompleted(
76+
const {
77+
ready: certCheckReady,
78+
}: TCACertificationCheckCompleted = useTCACertificationCheckCompleted(
7679
firstResourceProgress?.resourceProgressType ?? '',
7780
firstResourceProgress?.resourceProgressId ?? '',
7881
{ enabled: !!firstResourceProgress?.resourceProgressType },
7982
)
8083

81-
const tcaCertificationCompletedModal: ReactNode = useTcaCertificationModal(
82-
tcaCertificationName,
83-
navToCertificationDetails,
84-
)
85-
8684
if (ready && profile && !userInfo.current) {
8785
userInfo.current = { ...profile }
8886
}
@@ -119,11 +117,18 @@ const EnrollmentPage: FC<{}> = () => {
119117

120118
function closeEnrolledModal(): void {
121119
setIsEnrolledModalOpen(false)
122-
if (!tcaCertificationCompletedModal) {
123-
navToCertificationDetails()
124-
}
125120
}
126121

122+
useEffect(() => {
123+
if (!certCheckReady || isEnrolledModalOpen) {
124+
return
125+
}
126+
127+
refetchProgress()
128+
navToCertificationDetails()
129+
// eslint-disable-next-line react-hooks/exhaustive-deps
130+
}, [certCheckReady, isEnrolledModalOpen])
131+
127132
function renderMainContent(): ReactNode {
128133
return ready ? (
129134
<>
@@ -135,10 +140,8 @@ const EnrollmentPage: FC<{}> = () => {
135140

136141
<EnrolledModal
137142
isOpen={isEnrolledModalOpen}
138-
certification={certification}
139143
onClose={closeEnrolledModal}
140144
/>
141-
{!isEnrolledModalOpen && tcaCertificationCompletedModal}
142145
</>
143146
) : null
144147
}

0 commit comments

Comments
 (0)