Skip to content

Commit c56d2dc

Browse files
Fix More button and mobile newTab
1 parent 8e65477 commit c56d2dc

File tree

6 files changed

+25
-13
lines changed

6 files changed

+25
-13
lines changed

dist/dev/index.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/prod/index.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/IconSelect/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const IconSelect = ({ show, x, isResize }) => {
1010
// is window is on resize, stop animation
1111
if (isResize) {
1212
styleObj['transition'] = 'auto'
13-
styleObj['-webkit-transition'] = 'auto'
13+
styleObj['WebkitTransition'] = 'auto'
1414
}
1515
return <span
1616
className={styles.iconSelect}

src/components/TopNav/MobileMenu.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const MobileMenu = ({ menu, activeChildId, createHandleClickItem }) => (
1313
href={level2.href}
1414
key={`level2-${i}`}
1515
onClick={level2.subMenu && level2.subMenu.length > 0 ? createHandleClickItem(level2.id) : null}
16+
target={level2.openNewTab ? '_blank' : ''}
1617
>
1718
{level2.title}
1819
</a>

src/components/TopNav/PrimaryNav.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ const PrimaryNav = ({
8989
if ((level2.subMenu && level2.subMenu.length > 0) || level2.href) {
9090
return (
9191
level2.href
92-
? <Link
92+
? <a
9393
{...level2Params}
94-
to={level2.href}
95-
innerRef={createSetRef(level2.id)}
96-
openNewTab={level2.openNewTab}
94+
href={level2.href}
95+
ref={createSetRef(level2.id)}
96+
target={level2.openNewTab ? '_blank' : ''}
9797
>
9898
{level2.title}
99-
</Link>
99+
</a>
100100
: <span
101101
{...level2Params}
102102
ref={createSetRef(level2.id)}
@@ -130,8 +130,10 @@ const PrimaryNav = ({
130130
return (
131131
menu.href
132132
? <Link
133-
{...menuParams}
133+
className={styles.primaryLevel2}
134+
key={`more-item-${i}`}
134135
to={menu.href}
136+
openNewTab={menu.openNewTab}
135137
>
136138
{menu.title}
137139
</Link>

src/components/TopNav/PrimaryNav.module.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,10 @@
174174
justify-content: center;
175175
align-items: center;
176176

177+
svg {
178+
padding-left: 5px;
179+
}
180+
177181
.moreBtnMask {
178182
position: absolute;
179183
left: 0;
@@ -231,6 +235,11 @@
231235
@include transformVertical;
232236
}
233237
}
238+
239+
.primaryLevel2,
240+
a.primaryLevel2 {
241+
margin: 0;
242+
}
234243
}
235244

236245
.searchIcon {

0 commit comments

Comments
 (0)