issue #258 (#279)

Author: nqviet

src/components/challenge-detail/Header/ChallengeTags.jsx

@@ -38,7 +38,6 @@ export default function ChallengeTags(props) {
     challengeType,
     events,
     technPlatforms,
-    setChallengeListingFilter,
     openForRegistrationChallenges,
   } = props;
 
@@ -94,11 +93,6 @@ export default function ChallengeTags(props) {
     <div>
       {challengeType && (
         <TrackTag
-          onClick={() =>
-            setImmediate(() =>
-              setChallengeListingFilter({ types: [challengeType.name] })
-            )
-          }
           to={`${challengesUrl}${filterByChallengeType}&types[]=${encodeURIComponent(
             challengeType.abbreviation
           )}`}
@@ -124,9 +118,6 @@ export default function ChallengeTags(props) {
           tag && (
             <Tag
               key={tag}
-              onClick={() =>
-                setImmediate(() => setChallengeListingFilter({ tags: [tag] }))
-              }
               to={`${challengesUrl}${filterByTag}&tags[]=${encodeURIComponent(
                 tag
               )}`}
@@ -150,7 +141,6 @@ ChallengeTags.propTypes = {
   track: PT.string.isRequired,
   events: PT.arrayOf(PT.string),
   technPlatforms: PT.arrayOf(PT.string),
-  setChallengeListingFilter: PT.func.isRequired,
   challengeType: PT.shape().isRequired,
   openForRegistrationChallenges: PT.shape().isRequired,
 };

src/components/challenge-detail/Header/index.jsx

@@ -47,7 +47,6 @@ export default function ChallengeHeader(props) {
     onToggleDeadlines,
     registering,
     registerForChallenge,
-    setChallengeListingFilter,
     unregisterFromChallenge,
     unregistering,
     challengeTypesMap,
@@ -282,7 +281,6 @@ export default function ChallengeHeader(props) {
                 challengesUrl={challengesUrl}
                 events={eventNames}
                 technPlatforms={miscTags}
-                setChallengeListingFilter={setChallengeListingFilter}
                 openForRegistrationChallenges={openForRegistrationChallenges}
               />
               {(hasRecommendedChallenges || hasThriveArticles) && (
@@ -531,7 +529,6 @@ ChallengeHeader.propTypes = {
   registerForChallenge: PT.func.isRequired,
   registering: PT.bool.isRequired,
   selectedView: PT.string.isRequired,
-  setChallengeListingFilter: PT.func.isRequired,
   showDeadlineDetail: PT.bool.isRequired,
   unregisterFromChallenge: PT.func.isRequired,
   unregistering: PT.bool.isRequired,

src/containers/challenge-detail/index.jsx

@@ -360,7 +360,6 @@ class ChallengeDetailPageContainer extends React.Component {
       resultsLoadedForChallengeId,
       savingChallenge,
       selectedTab,
-      setChallengeListingFilter,
       setSpecsTabState,
       specsTabState,
       terms,
@@ -488,7 +487,6 @@ class ChallengeDetailPageContainer extends React.Component {
               selectedView={selectedTab}
               // hasRecommendedChallenges={displayRecommendedChallenges.length > 0}
               hasThriveArticles={thriveArticles.length > 0}
-              setChallengeListingFilter={setChallengeListingFilter}
               unregisterFromChallenge={() =>
                 unregisterFromChallenge(auth, challengeId)
               }
@@ -718,7 +716,6 @@ ChallengeDetailPageContainer.propTypes = {
   resultsLoadedForChallengeId: PT.string.isRequired,
   savingChallenge: PT.bool.isRequired,
   selectedTab: PT.string.isRequired,
-  setChallengeListingFilter: PT.func.isRequired,
   setSpecsTabState: PT.func.isRequired,
   specsTabState: PT.string.isRequired,
   terms: PT.arrayOf(PT.shape()),
@@ -967,18 +964,6 @@ const mapDispatchToProps = (dispatch) => {
         return challengeDetails;
       });
     },
-    setChallengeListingFilter: (change, stateProps) => {
-      const updateFilter = actions.filter.updateFilter;
-      const updateQuery = actions.filter.updateChallengeQuery;
-      change.page = 1;
-      change.tracks = constants.FILTER_CHALLENGE_TRACKS;
-      change.backet = constants.FILTER_BUCKETS[1];
-      if (change.tags) {
-        change.types = constants.FILTER_CHALLENGE_TYPES;
-      }
-      dispatch(updateFilter(change));
-      dispatch(updateQuery({ ...stateProps.filter.challenge, ...change }));
-    },
     setSpecsTabState: (state) =>
       dispatch(pageActions.page.challengeDetails.setSpecsTabState(state)),
     unregisterFromChallenge: (auth, challengeId) => {
@@ -1041,18 +1026,9 @@ const mapDispatchToProps = (dispatch) => {
   };
 };
 
-const mergeProps = (stateProps, dispatchProps, ownProps) => ({
-  ...ownProps,
-  ...stateProps,
-  ...dispatchProps,
-  setChallengeListingFilter: (filter) =>
-    dispatchProps.setChallengeListingFilter(filter, stateProps),
-});
-
 const ChallengeDetailContainer = connect(
   mapStateToProps,
   mapDispatchToProps,
-  mergeProps
 )(ChallengeDetailPageContainer);
 
 export default ChallengeDetailContainer;