Skip to content

Commit 351a090

Browse files
committed
Restructuring the register vs resource create
1 parent a04f900 commit 351a090

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

config/default.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ module.exports = {
2020
KAFKA_CLIENT_CERT: process.env.KAFKA_CLIENT_CERT,
2121
KAFKA_CLIENT_CERT_KEY: process.env.KAFKA_CLIENT_CERT_KEY,
2222

23+
SUBMITTER_ROLE_ID: process.env.SUBMITTER_ROLE_ID || '732339e7-8e30-49d7-9198-cccf9451e221',
24+
2325
CREATE_CHALLENGE_RESOURCE_TOPIC: process.env.CREATE_CHALLENGE_RESOURCE_TOPIC || 'challenge.action.resource.create',
2426
DELETE_CHALLENGE_RESOURCE_TOPIC: process.env.DELETE_CHALLENGE_RESOURCE_TOPIC || 'challenge.action.resource.delete',
2527

src/services/ProcessorService.js

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -69,24 +69,33 @@ async function _updateChallengeResource (message, isDelete) {
6969
}
7070
resourceRole = resourceRoleResponse.body[0]
7171
logger.debug(`Resource Role Response ${JSON.stringify(resourceRole)}`)
72-
const body = {}
7372
const userId = _.get(message, 'payload.memberId')
74-
// const body = {
75-
// roleId: resourceRole.legacyId,
76-
// resourceUserId: _.get(message, 'payload.memberId'),
77-
// isStudio: isStudio(v5Challenge.type)
78-
// }
73+
const body = {
74+
roleId: resourceRole.legacyId,
75+
resourceUserId: userId,
76+
isStudio: isStudio(v5Challenge.type)
77+
}
7978

8079
// create or delete the challenge resource from V4 API
8180
let response = null
82-
if (isDelete) {
83-
logger.debug(`Deleteing Challenge Resource ${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/register?userId=${userId} - ${JSON.stringify(body)}`)
84-
response = await helper.deleteRequest(`${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/register?userId=${userId}`, body, m2mToken)
81+
if (resourceRole.id === config.SUBMITTER_ROLE_ID) {
82+
if (isDelete) {
83+
logger.debug(`Unregistering Submitter ${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/unregister?userId=${userId} - ${JSON.stringify(body)}`)
84+
response = await helper.deleteRequest(`${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/unregister?userId=${userId}`, {}, m2mToken)
85+
} else {
86+
logger.debug(`Registering Submitter ${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/register?userId=${userId} - ${JSON.stringify(body)}`)
87+
response = await helper.postRequest(`${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/register?userId=${userId}`, {}, m2mToken)
88+
}
8589
} else {
86-
logger.debug(`POSTING Challenge Resource ${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/unregister?userId=${userId} - ${JSON.stringify(body)}`)
87-
response = await helper.postRequest(`${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/unregister?userId=${userId}`, body, m2mToken)
90+
if (isDelete) {
91+
logger.debug(`Deleteing Challenge Resource ${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/resources - ${JSON.stringify(body)}`)
92+
response = await helper.deleteRequest(`${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/resources`, body, m2mToken)
93+
} else {
94+
logger.debug(`Creating Challenge Resource ${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/resources - ${JSON.stringify(body)}`)
95+
response = await helper.postRequest(`${config.CHALLENGE_API_V4_URL}/${_.get(v5Challenge, 'legacyId')}/resources`, body, m2mToken)
96+
}
97+
logger.debug(`Update Challenge Response ${JSON.stringify(response)}`)
8898
}
89-
logger.debug(`Update Challenge Response ${JSON.stringify(response)}`)
9099
}
91100

92101
/**

0 commit comments

Comments
 (0)