Skip to content

Commit 8cc7a42

Browse files
author
Dushyant Bhalgami
committed
return inactive groups with m2m tokens
1 parent 3ab10ef commit 8cc7a42

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/controllers/GroupController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ async function searchGroups(req, res) {
1717
criteria.memberId = req.authUser.userId
1818
criteria.membershipType = config.MEMBERSHIP_TYPES.User
1919
}
20-
const result = await service.searchGroups(criteria, !req.authUser.isMachine && helper.hasAdminRole(req.authUser))
20+
const result = await service.searchGroups(criteria, req.authUser.isMachine || helper.hasAdminRole(req.authUser))
2121
helper.setResHeaders(req, res, result)
2222
res.send(result)
2323
}

src/services/GroupService.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const constants = require('../../app-constants')
1616
* @param {Boolean} isAdmin flag indicating whether the current user is an admin or not
1717
* @returns {Object} the search result
1818
*/
19-
async function searchGroups(criteria, isAdmin = false) {
19+
async function searchGroups(criteria, isAdmin) {
2020
logger.debug(`Search Group - Criteria - ${JSON.stringify(criteria)}`)
2121

2222
if ((criteria.memberId || criteria.universalUID) && !criteria.membershipType) {
@@ -94,7 +94,7 @@ async function searchGroups(criteria, isAdmin = false) {
9494
whereClause = ` WHERE g.status = '${constants.GroupStatus.Active}'`
9595
} else {
9696
whereClause = whereClause.concat(` AND g.status = '${constants.GroupStatus.Active}'`)
97-
}
97+
}
9898
}
9999

100100
// query total record count
@@ -167,7 +167,10 @@ searchGroups.schema = {
167167
privateGroup: Joi.boolean(),
168168
includeSubGroups: Joi.boolean().default(false),
169169
includeParentGroup: Joi.boolean().default(false),
170-
oneLevel: Joi.boolean()
170+
oneLevel: Joi.boolean(),
171+
status: Joi.string()
172+
.valid([constants.GroupStatus.Active, constants.GroupStatus.InActive])
173+
.default(constants.GroupStatus.Active)
171174
})
172175
}
173176

0 commit comments

Comments
 (0)