handle driver connection

Author: LieutenantRoger

app.js

@@ -14,6 +14,7 @@ const HttpStatus = require('http-status-codes')
 const morgan = require('morgan')
 const swaggerUi = require('swagger-ui-express')
 const YAML = require('yamljs')
+const { closeDB } = require('./src/common/helper')
 
 const swaggerDocument = YAML.load('./docs/swagger.yml')
 // setup express app
@@ -66,6 +67,12 @@ app.use((err, req, res, next) => {
   res.status(status).json(errorResponse)
 })
 
-app.listen(app.get('port'), () => {
+const server = app.listen(app.get('port'), () => {
   logger.info(`Express server listening on port ${app.get('port')}`)
 })
+
+server.close(async (error) => {
+  await closeDB()
+  logger.info('server closed')
+  process.exit(error ? 1 : 0)
+})

src/common/helper.js

@@ -63,6 +63,13 @@ function createDBSession () {
   return driver.session()
 }
 
+/**
+ * Close driver connection once the app exit
+ */
+async function closeDB () {
+  await driver.close()
+}
+
 /**
  * Ensure entity exists. Throw error if not exist.
  * @param {Object} session the db session
@@ -382,6 +389,7 @@ module.exports = {
   wrapExpress,
   autoWrapExpress,
   createDBSession,
+  closeDB,
   ensureExists,
   ensureGroupMember,
   getChildGroups,

src/controllers/GroupMembershipController.js

@@ -98,12 +98,11 @@ async function getMemberGroups (req, res) {
 * @param {*} req
 * @param {*} res
 */
-async function groupValidityCheck(req, res) {
+async function groupValidityCheck (req, res) {
   const result = await service.groupValidityCheck(req.params.memberId, req.params.groupId)
   res.send(result)
 }
 
-
 module.exports = {
   getGroupMembers,
   addGroupMember,

src/services/GroupMembershipService.js

@@ -565,7 +565,7 @@ getMemberGroups.schema = {
   })
 }
 
-async function groupValidityCheck(memberId, groupId) {
+async function groupValidityCheck (memberId, groupId) {
   const session = helper.createDBSession()
   try {
     const res = await session.run(
@@ -574,7 +574,7 @@ async function groupValidityCheck(memberId, groupId) {
 
     const validOrNot = _.includes(_.uniq(_.map(res.records, (record) => record.get(0))), groupId)
 
-    return {"check": validOrNot}
+    return { check: validOrNot }
   } catch (error) {
     logger.error(error)
     throw error