TCA-299 - handle lint fixes

Author: vas3a

client/src/components/formHelpers/form-fields.tsx

@@ -84,7 +84,7 @@ function FormFields(props: FormFieldsProps): JSX.Element {
                 name in placeholders ? placeholders[name] : '';
               const isURL = types[name] === 'url';
               return (
-                <FormGroup key={key} className="embedded">
+                <FormGroup key={key} className='embedded'>
                   {type === 'hidden' ? null : (
                     <ControlLabel htmlFor={key}>{label}</ControlLabel>
                   )}

client/src/components/layouts/prism.css

@@ -1,4 +1,4 @@
-pre[class*="language-"].line-numbers.line-numbers {
+pre[class*='language-'].line-numbers.line-numbers {
   border-radius: 8px;
   font-size: 14px;
   line-height: 22px;

client/src/components/layouts/variables.css

@@ -37,7 +37,7 @@
   --tc-link-blue-light: #5fb7ee;
   --tc-black: #000;
   --tc-black-100: #2a2a2a;
-  --tc-black-60: #7F7F7F;
+  --tc-black-60: #7f7f7f;
   --tc-black-40: #aaaaaa;
   --tc-black-20: #d4d4d4;
   --tc-black-10: #e9e9e9;

client/src/templates/Challenges/classic/action-row.tsx

@@ -30,7 +30,6 @@ const ActionRow = ({
   togglePane,
   showNotes,
   showPreview,
-  isMultifileCertProject,
   showInstructions,
   showConsole,
   superBlock,

client/src/templates/Challenges/classic/editor.tsx

@@ -573,7 +573,9 @@ const Editor = (props: EditorProps): JSX.Element => {
     attemptRef.current.attempts++;
   }
 
-  const tryToSubmitChallenge = debounce(props.submitChallenge, 2000, {leading: true});
+  const tryToSubmitChallenge = debounce(props.submitChallenge, 2000, {
+    leading: true
+  });
 
   function createLowerJaw(outputNode: HTMLElement, callback?: () => void) {
     const { output } = props;

client/src/templates/Challenges/classic/simple-editor.tsx

@@ -513,7 +513,9 @@ const SimpleEditor = (props: EditorProps): JSX.Element => {
     attemptRef.current.attempts++;
   }
 
-  const tryToSubmitChallenge = debounce(props.submitChallenge, 2000, {leading: true});
+  const tryToSubmitChallenge = debounce(props.submitChallenge, 2000, {
+    leading: true
+  });
 
   function resetMarginDecorations() {
     const { model, insideEditDecId } = dataRef.current;

client/src/templates/Challenges/codeally/show.tsx

@@ -33,6 +33,7 @@ import {
   isChallengeCompletedSelector,
   updateChallengeMeta,
   openModal,
+  submitChallenge,
   updateSolutionFormValues
 } from '../redux';
 import { createFlashMessage } from '../../../components/Flash/redux';
@@ -76,6 +77,7 @@ const mapDispatchToProps = (dispatch: Dispatch) =>
   bindActionCreators(
     {
       challengeMounted,
+      submitChallenge,
       createFlashMessage,
       hideCodeAlly,
       openCompletionModal: () => openModal('completion'),
@@ -93,6 +95,7 @@ interface ShowCodeAllyProps {
   createFlashMessage: typeof createFlashMessage;
   data: { challengeNode: ChallengeNode };
   hideCodeAlly: () => void;
+  submitChallenge: () => void;
   isChallengeCompleted: boolean;
   isSignedIn: boolean;
   openCompletionModal: () => void;
@@ -138,11 +141,7 @@ class ShowCodeAlly extends Component<ShowCodeAllyProps> {
     this.props.hideCodeAlly();
   }
 
-  handleSubmit = ({
-    showCompletionModal
-  }: {
-    showCompletionModal: boolean;
-  }) => {
+  handleSubmit = ({ completed }: { completed: boolean }) => {
     const {
       completedChallenges,
       createFlashMessage,
@@ -151,7 +150,7 @@ class ShowCodeAlly extends Component<ShowCodeAllyProps> {
           challenge: { id: challengeId }
         }
       },
-      openCompletionModal,
+      submitChallenge,
       partiallyCompletedChallenges
     } = this.props;
 
@@ -168,8 +167,8 @@ class ShowCodeAlly extends Component<ShowCodeAllyProps> {
         type: 'danger',
         message: FlashMessages.CompleteProjectFirst
       });
-    } else if (showCompletionModal) {
-      openCompletionModal();
+    } else if (completed) {
+      submitChallenge();
     }
   };
 

client/src/templates/Challenges/components/tool-panel.tsx

@@ -74,7 +74,9 @@ function ToolPanel({
 
   const { t } = useTranslation();
 
-  const tryToSubmitChallenge = debounce(submitChallenge, 2000, {leading: true});
+  const tryToSubmitChallenge = debounce(submitChallenge, 2000, {
+    leading: true
+  });
 
   return (
     <div

client/src/templates/Challenges/projects/backend/Show.tsx

@@ -174,13 +174,9 @@ class BackEnd extends Component<BackEndProps> {
     challengeMounted(challengeMeta.id);
   }
 
-  handleSubmit({
-    showCompletionModal
-  }: {
-    showCompletionModal: boolean;
-  }): void {
+  handleSubmit(): void {
     this.props.executeChallenge({
-      showCompletionModal
+      showCompletionModal: false
     });
   }
 

client/src/templates/Challenges/projects/frontend/Show.tsx

@@ -1,4 +1,4 @@
-import { Button, Grid, Col, Row } from '@freecodecamp/react-bootstrap';
+import { Grid, Col, Row } from '@freecodecamp/react-bootstrap';
 import { graphql } from 'gatsby';
 import React, { Component } from 'react';
 import Helmet from 'react-helmet';
@@ -37,7 +37,7 @@ const mapDispatchToProps = (dispatch: Dispatch) =>
       submitChallenge,
       updateChallengeMeta,
       challengeMounted,
-      updateSolutionFormValues,
+      updateSolutionFormValues
     },
     dispatch
   );
@@ -71,7 +71,7 @@ class Project extends Component<ProjectProps, ProjectState> {
 
     this.state = {
       completed: false,
-      hasErrors: false,
+      hasErrors: false
     };
 
     this.handleSubmit = this.handleSubmit.bind(this);
@@ -126,12 +126,8 @@ class Project extends Component<ProjectProps, ProjectState> {
     }
   }
 
-  handleSubmit({
-    completed
-  }: {
-    completed: boolean;
-  }): void {
-    this.setState({completed, hasErrors: !completed});
+  handleSubmit({ completed }: { completed: boolean }): void {
+    this.setState({ completed, hasErrors: !completed });
 
     const { submitChallenge } = this.props;
     if (completed) {

client/src/templates/Challenges/video/Show.tsx

@@ -46,7 +46,7 @@ const mapDispatchToProps = (dispatch: Dispatch) =>
       submitChallenge,
       updateChallengeMeta,
       challengeMounted,
-      updateSolutionFormValues,
+      updateSolutionFormValues
     },
     dispatch
   );
@@ -185,7 +185,6 @@ class ShowVideo extends Component<ShowVideoProps, ShowVideoState> {
             superBlock,
             certification,
             block,
-            translationPending,
             videoId,
             videoLocaleIds,
             bilibiliIds,
@@ -197,8 +196,7 @@ class ShowVideo extends Component<ShowVideoProps, ShowVideoState> {
         challengeMeta: { nextChallengePath, prevChallengePath }
       },
       t,
-      submitChallenge,
-      isChallengeCompleted
+      submitChallenge
     } = this.props;
 
     const blockNameTitle = `${t(
@@ -236,13 +234,21 @@ class ShowVideo extends Component<ShowVideoProps, ShowVideoState> {
               </Col>
 
               <Col md={8} mdOffset={2} sm={10} smOffset={1} xs={12}>
-                <h3 className="video-section-label">
-                    Question
-                </h3>
+                <h3 className='video-section-label'>Question</h3>
               </Col>
-              <Col md={8} mdOffset={2} sm={10} smOffset={1} xs={12} className="video-description">
+              <Col
+                md={8}
+                mdOffset={2}
+                sm={10}
+                smOffset={1}
+                xs={12}
+                className='video-description'
+              >
                 <ChallengeDescription description={description} />
-                <PrismFormatted className={'dark-palette line-numbers'} text={text} />
+                <PrismFormatted
+                  className={'dark-palette line-numbers'}
+                  text={text}
+                />
                 <Spacer />
                 <ObserveKeys>
                   <div className='video-quiz-options'>

client/src/templates/Challenges/video/show.css

@@ -68,7 +68,6 @@
   padding-bottom: 0;
 }
 
-
 .video-quiz-input-hidden {
   position: absolute;
   left: -9999px;