From e6f6e8b62abf61d17bb41c52970abb34f47015a1 Mon Sep 17 00:00:00 2001 From: Justin Gasper Date: Sun, 4 Sep 2022 12:19:06 +1000 Subject: [PATCH 1/4] Test for enabling dashboard on data science challenge --- .../Header/TabSelector/index.jsx | 2 +- .../challenge-detail/Submissions/index.jsx | 19 ++++++++++--------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx index b01cb53702..14175c3264 100644 --- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx +++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx @@ -300,7 +300,7 @@ export default function ChallengeViewSelector(props) { return ''; })()} { - isMM && ( + (isMM || challenge.track.toLowerCase() === 'data science') && ( Date: Sun, 4 Sep 2022 12:33:44 +1000 Subject: [PATCH 2/4] Fix lint complaint --- src/shared/components/challenge-detail/Submissions/index.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/components/challenge-detail/Submissions/index.jsx b/src/shared/components/challenge-detail/Submissions/index.jsx index a1e1ce0a7b..17260ceab8 100644 --- a/src/shared/components/challenge-detail/Submissions/index.jsx +++ b/src/shared/components/challenge-detail/Submissions/index.jsx @@ -71,6 +71,7 @@ class SubmissionsComponent extends React.Component { } this.updateSortedSubmissions(); } + componentDidUpdate(prevProps) { const isMM = this.isMM(); From 05a8f2eae3fa1c2644595a2d28254c9b6326a122 Mon Sep 17 00:00:00 2001 From: Justin Gasper Date: Sun, 4 Sep 2022 12:42:47 +1000 Subject: [PATCH 3/4] Fix lint again --- src/shared/components/challenge-detail/Submissions/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/challenge-detail/Submissions/index.jsx b/src/shared/components/challenge-detail/Submissions/index.jsx index 17260ceab8..486427c0c6 100644 --- a/src/shared/components/challenge-detail/Submissions/index.jsx +++ b/src/shared/components/challenge-detail/Submissions/index.jsx @@ -71,7 +71,7 @@ class SubmissionsComponent extends React.Component { } this.updateSortedSubmissions(); } - + componentDidUpdate(prevProps) { const isMM = this.isMM(); From 028fd7af2d7b9e10215cc0c344683ab82e563edd Mon Sep 17 00:00:00 2001 From: Justin Gasper Date: Fri, 9 Sep 2022 19:13:16 +1000 Subject: [PATCH 4/4] When switching to Submissions and Registrants tab from Dashboard tab, Details tab is opening https://github.com/topcoder-platform/community-app/issues/6633 --- src/shared/containers/challenge-detail/index.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/containers/challenge-detail/index.jsx b/src/shared/containers/challenge-detail/index.jsx index fc026000f8..361b414712 100644 --- a/src/shared/containers/challenge-detail/index.jsx +++ b/src/shared/containers/challenge-detail/index.jsx @@ -256,7 +256,8 @@ class ChallengeDetailPageContainer extends React.Component { history.push(history.location.pathname, history.state); } - if (!checkIsMM(challenge) && selectedTab === DETAIL_TABS.MM_DASHBOARD) { + if (!checkIsMM(challenge) && COMPETITION_TRACKS_V3.DS !== challenge.track + && selectedTab === DETAIL_TABS.MM_DASHBOARD) { onSelectorClicked(DETAIL_TABS.DETAILS); }