From 3005f2fc15a96936ee4a998384d02aeabd0c6f42 Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Thu, 18 Jul 2019 23:25:49 +0530 Subject: [PATCH 1/7] Update index.jsx --- src/shared/components/TopcoderHeader/index.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index 8bbadc5b75..5087bffd58 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -358,6 +358,7 @@ export default class TopcoderHeader extends React.Component { {userMenuHandle} {authButtons}
!isMobile && openSearch(event.target)} From 350b00e0d0a82079b2199537bde78b92aa78942f Mon Sep 17 00:00:00 2001 From: prakashdurlabhji Date: Fri, 19 Jul 2019 14:31:42 +0530 Subject: [PATCH 2/7] fix --- .eslintrc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index ddc5f09737..49b94e875d 100644 --- a/.eslintrc +++ b/.eslintrc @@ -2,7 +2,13 @@ "extends": "./node_modules/topcoder-react-utils/config/eslint/default.json", "rules": { "jsx-a11y/anchor-is-valid": false, - "import/no-cycle": [2, { "maxDepth": 1 }] + "import/no-cycle": [2, { "maxDepth": 1 }], + "jsx-a11y/no-noninteractive-tabindex": [ + { + "tags": ["h4", "div"], + "roles": [], + }, + ] }, "env": { "browser": true From c8a71889f79c0cc87090054a760fba622d3922f1 Mon Sep 17 00:00:00 2001 From: prakashdurlabhji Date: Fri, 19 Jul 2019 15:05:02 +0530 Subject: [PATCH 3/7] test fix --- .../components/TopcoderHeader/__snapshots__/index.jsx.snap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap index c8d287309f..559e4bd95f 100644 --- a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap +++ b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap @@ -70,6 +70,7 @@ exports[`Default render 1`] = ` onMouseEnter={[Function]} onMouseLeave={[Function]} onTouchStart={[Function]} + tabIndex={0} > Date: Fri, 26 Jul 2019 00:28:34 +0530 Subject: [PATCH 4/7] Update .eslintrc --- .eslintrc | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.eslintrc b/.eslintrc index 49b94e875d..ae3e3c2aab 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,14 +1,7 @@ { "extends": "./node_modules/topcoder-react-utils/config/eslint/default.json", "rules": { - "jsx-a11y/anchor-is-valid": false, - "import/no-cycle": [2, { "maxDepth": 1 }], - "jsx-a11y/no-noninteractive-tabindex": [ - { - "tags": ["h4", "div"], - "roles": [], - }, - ] + "jsx-a11y/anchor-is-valid": false }, "env": { "browser": true From c287d2c00747939aeb2cce3d757b43dd3ce678a9 Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Fri, 26 Jul 2019 00:28:52 +0530 Subject: [PATCH 5/7] Update .eslintrc --- .eslintrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index ae3e3c2aab..ddc5f09737 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,7 +1,8 @@ { "extends": "./node_modules/topcoder-react-utils/config/eslint/default.json", "rules": { - "jsx-a11y/anchor-is-valid": false + "jsx-a11y/anchor-is-valid": false, + "import/no-cycle": [2, { "maxDepth": 1 }] }, "env": { "browser": true From 41b5ac0357654ecef6358fbbc57a98c12ac59982 Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Fri, 26 Jul 2019 00:29:27 +0530 Subject: [PATCH 6/7] Update index.jsx --- src/shared/components/TopcoderHeader/index.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index 5087bffd58..e5a8552ee2 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -358,6 +358,7 @@ export default class TopcoderHeader extends React.Component { {userMenuHandle} {authButtons}
Date: Fri, 26 Jul 2019 02:39:27 +0530 Subject: [PATCH 7/7] Update index.jsx.snap --- .../components/TopcoderHeader/__snapshots__/index.jsx.snap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap index 559e4bd95f..be3a03705b 100644 --- a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap +++ b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap @@ -70,6 +70,7 @@ exports[`Default render 1`] = ` onMouseEnter={[Function]} onMouseLeave={[Function]} onTouchStart={[Function]} + role="button" tabIndex={0} >