Fix sorted of by 'Most recent' of My Challenges bucket and sorted by 'Review start date' of Open for Review bucket

to be based of challenge start date in descending order.

Author: gets0ul

src/shared/reducers/challenge-listing/index.js

@@ -812,7 +812,7 @@ function create(initialState) {
     sorts: {
       ongoing: 'updated',
       openForRegistration: 'updated',
-      my: 'updated',
+      my: 'startDate',
       // past: 'updated',
       reviewOpportunities: 'review-opportunities-start-date',
     },

src/shared/utils/challenge-listing/buckets.js

@@ -35,7 +35,7 @@ export const BUCKET_DATA = {
     // hideCount: false,
     name: 'My Challenges',
     sorts: [
-      SORTS.MOST_RECENT,
+      SORTS.MOST_RECENT_START_DATE,
       // SORTS.TIME_TO_SUBMIT,
       // SORTS.NUM_REGISTRANTS,
       // SORTS.NUM_SUBMISSIONS,

src/shared/utils/challenge-listing/sort.js

@@ -8,6 +8,7 @@ import { sumBy } from 'lodash';
 export const SORTS = {
   // CURRENT_PHASE: 'current-phase',
   MOST_RECENT: 'updated',
+  MOST_RECENT_START_DATE: 'startDate',
   // NUM_REGISTRANTS: 'num-registrants',
   // NUM_SUBMISSIONS: 'num-submissions',
   // PRIZE_HIGH_TO_LOW: 'prize-high-to-low',
@@ -29,6 +30,10 @@ export default {
     name: 'Most recent',
     order: 'desc',
   },
+  [SORTS.MOST_RECENT_START_DATE]: {
+    name: 'Most recent',
+    order: 'desc',
+  },
   // [SORTS.NUM_REGISTRANTS]: {
   //   func: (a, b) => b.numOfRegistrants - a.numOfRegistrants,
   //   name: '# of registrants',
@@ -89,7 +94,7 @@ export default {
   },
   [SORTS.REVIEW_OPPORTUNITIES_START_DATE]: {
     // This will implicitly use moment#valueOf
-    func: (a, b) => moment(a.startDate) - moment(b.startDate),
+    func: (a, b) => moment(b.startDate) - moment(a.startDate), // descending
     name: 'Review start date',
   },
 };