Skip to content

Commit b1065a4

Browse files
r0hit-guptar0hit-gupta
authored
Merge branch 'qa-accessibility' into msft30
2 parents e9f39dc + a5244bf commit b1065a4

File tree

33 files changed

+2821
-2654
lines changed

33 files changed

+2821
-2654
lines changed

‎.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ workflows:
184184
only:
185185
- legacy-tco
186186
- hot-fixes-3
187+
- qa-accessibility
187188
# This is beta env for production soft releases
188189
- "build-prod-beta":
189190
context : org-global

‎.eslintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
"extends": "./node_modules/topcoder-react-utils/config/eslint/default.json",
33
"rules": {
44
"jsx-a11y/anchor-is-valid": false,
5-
"import/no-cycle": [2, { "maxDepth": 1 }]
5+
"import/no-cycle": [2, { "maxDepth": 1 }],
6+
"react/prop-types": ["error", { "ignore": ["challenge","eventDetails","winner","bucket","theme","submissionObject","profile","communitiesList","meta","scoreboard","item","activeTrigger","menuItems","scoreboard"] }]
67
},
78
"env": {
89
"browser": true

‎__tests__/shared/__snapshots__/index.jsx.snap

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ exports[`Snapshot match 1`] = `
55
<HelmetWrapper
66
defer={true}
77
encodeSpecialCharacters={true}
8+
htmlAttributes={
9+
Object {
10+
"lang": "en",
11+
}
12+
}
813
>
914
<meta
1015
content="#FFFFFF"
@@ -34,6 +39,11 @@ exports[`Snapshot match 2`] = `
3439
<HelmetWrapper
3540
defer={true}
3641
encodeSpecialCharacters={true}
42+
htmlAttributes={
43+
Object {
44+
"lang": "en",
45+
}
46+
}
3747
>
3848
<meta
3949
content="#FFFFFF"

‎__tests__/shared/components/ProfilePage/Header/__snapshots__/index.jsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ exports[`renders profile about header correctly 1`] = `
2121
className="src-shared-components-ProfilePage-Header-___styles__handle___-v11j"
2222
style={
2323
Object {
24-
"color": "#9D9FA0",
24+
"color": "#555555",
2525
}
2626
}
2727
>

‎__tests__/shared/components/ProfilePage/Skill/__snapshots__/index.jsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ exports[`renders a skill correctly 1`] = `
55
className="src-shared-components-ProfilePage-Skill-___styles__container___bW089"
66
>
77
<div
8+
aria-label="Test Skill Icon"
89
className="src-shared-components-ProfilePage-Skill-___styles__skill-icon___1-d49"
910
>
1011
<FallbackIcon

‎__tests__/shared/components/TopcoderHeader/__snapshots__/Auth.jsx.snap

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
exports[`Snapshot match 1`] = `
44
<div
55
className="src-shared-components-TopcoderHeader-Auth-___style__auth___3X0_r"
6-
onClick={[Function]}
7-
onKeyPress={null}
8-
role="button"
9-
tabIndex="0"
106
>
117
<a
128
className="tc-btn-sm tc-btn-primary"
@@ -27,10 +23,6 @@ exports[`Snapshot match 1`] = `
2723
exports[`Snapshot match 2`] = `
2824
<div
2925
className="column src-shared-components-TopcoderHeader-Auth-___style__auth___3X0_r"
30-
onClick={[Function]}
31-
onKeyPress={null}
32-
role="button"
33-
tabIndex="0"
3426
>
3527
<a
3628
className="tc-btn-sm tc-btn-primary"

‎__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap

Lines changed: 40 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ exports[`Default render 1`] = `
99
className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
1010
>
1111
<a
12+
aria-label="Topcoder Homepage"
1213
className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
1314
href="https://www.topcoder-dev.com"
1415
>
@@ -29,7 +30,12 @@ exports[`Default render 1`] = `
2930
onMouseLeave={[Function]}
3031
onTouchStart={[Function]}
3132
>
32-
Compete
33+
<span
34+
role="link"
35+
tabIndex={0}
36+
>
37+
Compete
38+
</span>
3339
</li>
3440
<li
3541
className="src-shared-components-TopcoderHeader-___style__main-menu-item___2KIu6"
@@ -51,7 +57,12 @@ exports[`Default render 1`] = `
5157
onMouseLeave={[Function]}
5258
onTouchStart={[Function]}
5359
>
54-
Community
60+
<span
61+
role="link"
62+
tabIndex={0}
63+
>
64+
Community
65+
</span>
5566
</li>
5667
</ul>
5768
<div
@@ -274,6 +285,7 @@ exports[`Render with open menu 1`] = `
274285
className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
275286
>
276287
<a
288+
aria-label="Topcoder Homepage"
277289
className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
278290
href="https://www.topcoder-dev.com"
279291
>
@@ -294,7 +306,12 @@ exports[`Render with open menu 1`] = `
294306
onMouseLeave={[Function]}
295307
onTouchStart={[Function]}
296308
>
297-
Compete
309+
<span
310+
role="link"
311+
tabIndex={0}
312+
>
313+
Compete
314+
</span>
298315
</li>
299316
<li
300317
className="src-shared-components-TopcoderHeader-___style__main-menu-item___2KIu6"
@@ -316,7 +333,12 @@ exports[`Render with open menu 1`] = `
316333
onMouseLeave={[Function]}
317334
onTouchStart={[Function]}
318335
>
319-
Community
336+
<span
337+
role="link"
338+
tabIndex={0}
339+
>
340+
Community
341+
</span>
320342
</li>
321343
</ul>
322344
<div
@@ -550,6 +572,7 @@ exports[`Render with specified profile 1`] = `
550572
className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
551573
>
552574
<a
575+
aria-label="Topcoder Homepage"
553576
className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
554577
href="https://www.topcoder-dev.com"
555578
>
@@ -570,7 +593,12 @@ exports[`Render with specified profile 1`] = `
570593
onMouseLeave={[Function]}
571594
onTouchStart={[Function]}
572595
>
573-
Compete
596+
<span
597+
role="link"
598+
tabIndex={0}
599+
>
600+
Compete
601+
</span>
574602
</li>
575603
<li
576604
className="src-shared-components-TopcoderHeader-___style__main-menu-item___2KIu6"
@@ -592,7 +620,12 @@ exports[`Render with specified profile 1`] = `
592620
onMouseLeave={[Function]}
593621
onTouchStart={[Function]}
594622
>
595-
Community
623+
<span
624+
role="link"
625+
tabIndex={0}
626+
>
627+
Community
628+
</span>
596629
</li>
597630
</ul>
598631
<div
@@ -609,7 +642,7 @@ exports[`Render with specified profile 1`] = `
609642
className="src-shared-components-TopcoderHeader-___style__user-menu-handle___r6kbg"
610643
style={
611644
Object {
612-
"color": "#9D9FA0",
645+
"color": "#555555",
613646
}
614647
}
615648
/>

‎__tests__/shared/components/TopcoderHeader/mobile/__snapshots__/UserMenu.jsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ exports[`Snapshot match 1`] = `
1818
className="src-shared-components-TopcoderHeader-mobile-UserMenu-___style__handle___CL0Tq"
1919
style={
2020
Object {
21-
"color": "#9D9FA0",
21+
"color": "#555555",
2222
}
2323
}
2424
>

‎__tests__/shared/components/__snapshots__/Handle.jsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ exports[`Matches shallow shapshot 1`] = `
66
href=""
77
style={
88
Object {
9-
"color": "#9D9FA0",
9+
"color": "#555555",
1010
"fontSize": "24px",
1111
}
1212
}

‎__tests__/shared/components/__snapshots__/TopcoderFooter.jsx.snap

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ exports[`Matches shallow shapshot 1`] = `
55
className="src-shared-components-TopcoderFooter-___style__footer___28yQ6"
66
>
77
<nav>
8-
<ul>
8+
<ol>
99
<li
1010
className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
1111
>
@@ -51,13 +51,14 @@ exports[`Matches shallow shapshot 1`] = `
5151
TERMS
5252
</a>
5353
</li>
54-
</ul>
54+
</ol>
5555
</nav>
5656
<div
5757
className="src-shared-components-TopcoderFooter-___style__social-links___2G4Ia"
5858
>
5959
<hr />
6060
<a
61+
aria-label="Facebook"
6162
href="https://www.facebook.com/topcoder"
6263
target="fbwindow"
6364
>
@@ -78,6 +79,7 @@ exports[`Matches shallow shapshot 1`] = `
7879
</svg>
7980
</a>
8081
<a
82+
aria-label="Twitter"
8183
href="http://www.twitter.com/topcoder"
8284
target="twwindow"
8385
>
@@ -98,6 +100,7 @@ exports[`Matches shallow shapshot 1`] = `
98100
</svg>
99101
</a>
100102
<a
103+
aria-label="Linkedin"
101104
href="https://www.linkedin.com/company/topcoder"
102105
target="liwindow"
103106
>
@@ -118,6 +121,7 @@ exports[`Matches shallow shapshot 1`] = `
118121
</svg>
119122
</a>
120123
<a
124+
aria-label="Instagram"
121125
href="https://www.instagram.com/topcoder"
122126
target="inwindow"
123127
>

‎__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeFilters.jsx.snap

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
108108
/>
109109
<span>
110110
<span
111+
aria-checked={false}
112+
aria-label="Filter"
111113
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
114+
role="switch"
112115
>
113116
<ThemedSwitchWithLabel
114117
composeAdhocTheme="deeply"
@@ -122,7 +125,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
122125
/>
123126
</span>
124127
<span
128+
aria-checked={false}
129+
aria-label="Filter"
125130
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
131+
role="switch"
126132
>
127133
<ThemedSwitchWithLabel
128134
composeAdhocTheme="deeply"
@@ -136,7 +142,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
136142
/>
137143
</span>
138144
<span
145+
aria-checked={false}
146+
aria-label="Filter"
139147
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
148+
role="switch"
140149
>
141150
<ThemedSwitchWithLabel
142151
composeAdhocTheme="deeply"

‎__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ exports[`Matches shallow shapshot 1`] = `
55
className="tc-outline-btn name src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersSwitch___2ixiH"
66
onClick={[Function]}
77
onKeyPress={[Function]}
8+
role="button"
9+
tabIndex={0}
810
>
911
<FiltersIcon
1012
className="src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersIcon___OqBJh"
@@ -22,6 +24,8 @@ exports[`Matches shallow shapshot 2`] = `
2224
className="tc-outline-btn name src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersSwitch___2ixiH src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__active___2wLTl"
2325
onClick={[Function]}
2426
onKeyPress={[Function]}
27+
role="button"
28+
tabIndex={0}
2529
>
2630
<FiltersIcon
2731
className="src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersIcon___OqBJh"

0 commit comments

Comments
 (0)