Skip to content

Commit 9f583e4

Browse files
authored
Merge pull request #4440 from PrakashDurlabhji/issue_4436
Issue 4436
2 parents ffcab5b + 7041a16 commit 9f583e4

File tree

2 files changed

+20
-13
lines changed
  • src/shared/components/challenge-listing

2 files changed

+20
-13
lines changed

src/shared/components/challenge-listing/ChallengeCard/index.jsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,15 @@ function ChallengeCard({
9191
{challenge.status === 'Active' ? 'Ends ' : 'Ended '}
9292
{getEndDate(challenge, challengeTypes)}
9393
</span>
94-
<Tags
95-
tags={challenge.tags}
96-
onTechTagClicked={onTechTagClicked}
97-
isExpanded={expandedTags.includes(challenge.id)}
98-
expand={() => expandTag(challenge.id)}
99-
/>
94+
{ challenge.tags.length > 0
95+
&& (
96+
<Tags
97+
tags={challenge.tags}
98+
onTechTagClicked={onTechTagClicked}
99+
isExpanded={expandedTags.includes(challenge.id)}
100+
expand={() => expandTag(challenge.id)}
101+
/>
102+
) }
100103
</div>
101104
</div>
102105
</div>

src/shared/components/challenge-listing/ReviewOpportunityCard/index.jsx

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ function ReviewOpportunityCard({
4848
}) {
4949
const { challenge } = opportunity;
5050
const { subTrack, legacy } = challenge;
51-
const tags = challenge.tags || challenge.technologies;
51+
let tags = challenge.tags || challenge.technologies;
52+
tags = tags.filter(tag => tag.trim().length);
5253
const track = legacy ? legacy.track : challenge.track;
5354
const start = moment(opportunity.startDate);
5455
return (
@@ -80,12 +81,15 @@ function ReviewOpportunityCard({
8081
{' '}
8182
{start.format('MMM DD')}
8283
</span>
83-
<Tags
84-
tags={tags}
85-
isExpanded={(expandedTags || []).includes(challenge.id)}
86-
expand={() => expandTag(challenge.id)}
87-
onTechTagClicked={onTechTagClicked}
88-
/>
84+
{ tags.length > 0
85+
&& (
86+
<Tags
87+
tags={tags}
88+
isExpanded={(expandedTags || []).includes(challenge.id)}
89+
expand={() => expandTag(challenge.id)}
90+
onTechTagClicked={onTechTagClicked}
91+
/>
92+
) }
8993
</div>
9094
</div>
9195
</div>

0 commit comments

Comments
 (0)