Issue#4641 : Fix forum link

Author: luizrrodrigues

src/shared/components/Dashboard/Program/IosCard.jsx

@@ -9,7 +9,7 @@ import './IosCard.scss';
 const IosCard = (props) => {
   const { challenge } = props;
   const { legacy } = challenge;
-  const { track } = legacy;
+  const { track, forumId } = legacy;
   return (
     <div styleName={`challenge tile-view ${track}`}>
       <div styleName="challenge-track" />
@@ -39,7 +39,7 @@ const IosCard = (props) => {
               </p>
             </a>
           </div>
-          <a href={`${config.URL.FORUMS}/?module=Category&categoryID=${challenge.forumId}`} styleName="forum">
+          <a href={`${config.URL.FORUMS}/?module=Category&categoryID=${forumId}`} styleName="forum">
             <div styleName="forum-icon" />
             <p>
               Posts

src/shared/components/challenge-detail/Header/TabSelector/index.jsx

@@ -33,7 +33,7 @@ export default function ChallengeViewSelector(props) {
     mySubmissions,
   } = props;
 
-  const forumId = _.get(challenge, 'forumId') || 0;
+  const forumId = _.get(challenge, 'legacy.forumId') || 0;
   const roles = _.get(challenge, 'userDetails.roles') || [];
 
   const forumEndpoint = trackLower === 'design'
@@ -199,8 +199,8 @@ ChallengeViewSelector.propTypes = {
   isLoggedIn: PT.bool,
   challenge: PT.shape({
     subTrack: PT.any,
-    details: PT.shape({
-      forumId: PT.number.isRequired,
+    legacy: PT.shape({
+      forumId: PT.number,
     }),
     userDetails: PT.shape({
       roles: PT.arrayOf(PT.string),

src/shared/components/challenge-detail/Specification/index.jsx

@@ -38,7 +38,6 @@ export default function ChallengeDetailsView(props) {
   } = props;
 
   const {
-    forumId,
     groups,
     description,
     privateDescription,
@@ -53,7 +52,12 @@ export default function ChallengeDetailsView(props) {
 
   const tags = challenge.tags || [];
   const roles = (userDetails || {}).roles || [];
-  const { track, reviewScorecardId, screeningScorecardId } = legacy;
+  const {
+    track,
+    reviewScorecardId,
+    screeningScorecardId,
+    forumId,
+  } = legacy;
 
   const allowStockArt = _.find(metadata, { type: 'allowStockArt' });
   let environment = '';
@@ -415,9 +419,9 @@ ChallengeDetailsView.propTypes = {
       track: PT.string.isRequired,
       reviewScorecardId: PT.string,
       screeningScorecardId: PT.string,
+      forumId: PT.number,
     }),
     groups: PT.any,
-    forumId: PT.number,
     reviewType: PT.string,
     tags: PT.arrayOf(PT.string),
     numberOfCheckpointsPrizes: PT.number,

src/shared/components/challenge-listing/ChallengeCard/Status/index.jsx

@@ -164,6 +164,7 @@ export default function ChallengeStatus(props) {
    * the common code being used in both places. */
   function completedChallenge() {
     const { challenge } = props;
+    const forumId = _.get(challenge, 'legacy.forumId') || 0;
     return (
       <div>
         {renderLeaderboard()}
@@ -191,7 +192,7 @@ export default function ChallengeStatus(props) {
             challenge.myChallenge
             && (
               <div styleName="spacing">
-                <a styleName="link-forum past" href={`${FORUM_URL}${challenge.forumId}`}>
+                <a styleName="link-forum past" href={`${FORUM_URL}${forumId}`}>
                   <ForumIcon />
                 </a>
               </div>
@@ -205,12 +206,12 @@ export default function ChallengeStatus(props) {
   function activeChallenge() {
     const { challenge } = props;
     const {
-      forumId,
       myChallenge,
       status,
       subTrack,
     } = challenge;
     const allPhases = challenge.phases || [];
+    const forumId = _.get(challenge, 'legacy.forumId') || 0;
 
     let statusPhase = allPhases
       .filter(p => p.name !== 'Registration' && p.isOpen)