Skip to content

Commit 43ed0b4

Browse files
committed
changes for MSFT-259
1 parent 77efb79 commit 43ed0b4

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/shared/components/Tooltip/index.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@ function Tooltip({
2121
suppressDiv,
2222
trigger,
2323
defaultVisible,
24+
id,
2425
}) {
2526
return (
2627
<RCTooltip
28+
id={id}
2729
placement={position}
2830
overlay={content}
2931
overlayClassName={className}
@@ -49,6 +51,7 @@ Tooltip.defaultProps = {
4951
position: 'top',
5052
className: '',
5153
content: '',
54+
id: '',
5255
onTooltipHover: _.noop,
5356
placeArrow: _.noop,
5457
suppressDiv: false,
@@ -60,6 +63,7 @@ Tooltip.propTypes = {
6063
align: PT.shape({}),
6164
position: PT.string,
6265
children: PT.node.isRequired,
66+
id: PT.string,
6367
className: PT.string,
6468
content: PT.node,
6569
onTooltipHover: PT.func,

src/shared/components/challenge-detail/Specification/SideBar/index.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ Final Review:
108108
</h3>
109109
<span styleName="link-like-paragraph tooltip-container">
110110
{reviewTypeTitle}
111-
<Tooltip content={reviewTip} trigger={['hover', 'focus']}>
112-
<div styleName="tctooltip" tabIndex="0" role="button">
111+
<Tooltip id="review-tip" content={reviewTip} trigger={['hover', 'focus']}>
112+
<div styleName="tctooltip" tabIndex="0" role="button" aria-describedBy="review-tip">
113113
?
114114
</div>
115115
</Tooltip>
@@ -119,8 +119,8 @@ Approval:
119119
</h3>
120120
<span styleName="link-like-paragraph tooltip-container">
121121
User Sign-Off
122-
<Tooltip content={approvalTip} className={styles['tooltip-overlay']} trigger={['hover', 'focus']}>
123-
<div styleName="tctooltip" tabIndex="0" role="button">
122+
<Tooltip id="approval-tip" content={approvalTip} className={styles['tooltip-overlay']} trigger={['hover', 'focus']}>
123+
<div styleName="tctooltip" tabIndex="0" role="button" aria-describedBy="approval-tip">
124124
?
125125
</div>
126126
</Tooltip>

0 commit comments

Comments
 (0)