optimized code

Author: himani-raghav

src/services/vanilla.js

@@ -208,9 +208,10 @@ async function createVanillaGroup (challenge) {
       const groupNameTemplate = _.template(groupTemplate.group.name)
       const groupDescriptionTemplate = challenge.legacy.selfService ? _.template(groupTemplate.group.selfServiceDescription)
         : _.template(groupTemplate.group.description)
+      const shorterGroupName = groupNameTemplate({ challengeDetailsDiscussion }).substring(0,config.FORUM_TITLE_LENGTH_LIMIT);
 
       const { body: group } = await vanillaClient.createGroup({
-        name: groupNameTemplate({ challengeDetailsDiscussion }).length >= config.FORUM_TITLE_LENGTH_LIMIT ? groupNameTemplate({ challengeDetailsDiscussion }).slice(0,config.FORUM_TITLE_LENGTH_LIMIT) + "..." : groupNameTemplate({ challengeDetailsDiscussion }),
+        name: groupNameTemplate({ challengeDetailsDiscussion }).length >= config.FORUM_TITLE_LENGTH_LIMIT ? `${shorterGroupName}...` : groupNameTemplate({ challengeDetailsDiscussion }),
         privacy: groupTemplate.group.privacy,
         type: groupTemplate.group.type,
         description: groupDescriptionTemplate({ challenge }),