From 39d249ab129d8f6a05c6c2afaa8613e2b72d1886 Mon Sep 17 00:00:00 2001 From: Thomas Kranitsas Date: Thu, 13 Apr 2023 17:45:11 +0300 Subject: [PATCH] allow admins/m2m to change the timelineTemplateId --- src/services/ChallengeService.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js index f96c4a9e..6bc788c6 100644 --- a/src/services/ChallengeService.js +++ b/src/services/ChallengeService.js @@ -1616,8 +1616,8 @@ async function updateChallenge(currentUser, challengeId, data) { // TODO: Fix this Tech Debt once legacy is turned off const finalStatus = data.status || challenge.status; const finalTimelineTemplateId = data.timelineTemplateId || challenge.timelineTemplateId; - const timelineTemplateChanged = false; - if (!_.get(data, "legacy.pureV5") && !_.get(challenge, "legacy.pureV5")) { + let timelineTemplateChanged = false; + if (!currentUser.isMachine && !hasAdminRole(currentUser) && !_.get(data, "legacy.pureV5") && !_.get(challenge, "legacy.pureV5")) { if ( finalStatus !== constants.challengeStatuses.New && finalTimelineTemplateId !== challenge.timelineTemplateId @@ -1750,7 +1750,7 @@ async function updateChallenge(currentUser, challengeId, data) { const { track, type } = await challengeHelper.validateAndGetChallengeTypeAndTrack({ typeId: challenge.typeId, trackId: challenge.trackId, - timelineTemplateId: challenge.timelineTemplateId, + timelineTemplateId: timelineTemplateChanged ? finalTimelineTemplateId : challenge.timelineTemplateId, }); if (_.get(type, "isTask")) {