diff --git a/app-constants.js b/app-constants.js index de6ddffc..72ddaa49 100644 --- a/app-constants.js +++ b/app-constants.js @@ -85,6 +85,11 @@ const challengeTextSortField = { TypeId: 'typeId' } +const reviewTypes = { + Community: 'COMMUNITY', + Internal: 'INTERNAL' +} + module.exports = { UserRoles, prizeSetTypes, @@ -95,5 +100,6 @@ module.exports = { Topics, challengeTracks, challengeTextSortField, - DiscussionTypes + DiscussionTypes, + reviewTypes } diff --git a/docs/swagger.yaml b/docs/swagger.yaml index a4a738a2..8be8a99a 100644 --- a/docs/swagger.yaml +++ b/docs/swagger.yaml @@ -2550,6 +2550,10 @@ definitions: reviewType: type: string description: the review type + enum: + - 'INTERNAL' + - 'COMMUNITY' + default: 'INTERNAL' forumId: type: integer description: the forum id @@ -2718,7 +2722,6 @@ definitions: - prizeSets - created - createdBy - - reviewType - tags - status Attachment: @@ -2962,13 +2965,16 @@ definitions: type: string reviewType: type: string + enum: + - 'INTERNAL' + - 'COMMUNITY' + default: 'INTERNAL' confidentialityType: type: string forumId: type: number required: - track - - reviewType name: type: string description: @@ -3246,7 +3252,6 @@ definitions: - prizeSets - created - createdBy - - reviewType - tags - projectId - forumId diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js index 74ef3a63..d6205ea1 100644 --- a/src/services/ChallengeService.js +++ b/src/services/ChallengeService.js @@ -959,7 +959,7 @@ createChallenge.schema = { typeId: Joi.id(), trackId: Joi.id(), legacy: Joi.object().keys({ - reviewType: Joi.string().required(), + reviewType: Joi.string().valid(_.values(constants.reviewTypes)).default(constants.reviewTypes.Internal), confidentialityType: Joi.string().default(config.DEFAULT_CONFIDENTIALITY_TYPE), forumId: Joi.number().integer(), directProjectId: Joi.number().integer(), @@ -1703,7 +1703,7 @@ fullyUpdateChallenge.schema = { challengeId: Joi.id(), data: Joi.object().keys({ legacy: Joi.object().keys({ - reviewType: Joi.string().required(), + reviewType: Joi.string().valid(_.values(constants.reviewTypes)).default(constants.reviewTypes.Internal), confidentialityType: Joi.string().default(config.DEFAULT_CONFIDENTIALITY_TYPE), forumId: Joi.number().integer(), directProjectId: Joi.number().integer(), @@ -1802,7 +1802,7 @@ partiallyUpdateChallenge.schema = { legacy: Joi.object().keys({ track: Joi.string(), subTrack: Joi.string(), - reviewType: Joi.string(), + reviewType: Joi.string().valid(_.values(constants.reviewTypes)).default(constants.reviewTypes.Internal), confidentialityType: Joi.string().default(config.DEFAULT_CONFIDENTIALITY_TYPE), directProjectId: Joi.number(), forumId: Joi.number().integer(),